Refactor StripInhoms #121
Merged
Refactor StripInhoms #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rename to Xsection, XsectionMaq, Xsection3D - add ModelXsection for cross-section models - rename StripAreaSink to XsectionAreaSink - add SimpleAquifer for cross-section models - fix imports update examples - update docs - deprecation warnings for old object names
|
Looks good. One question: I thought there used to be a notebook where a StripAreaSink was compared to an inhomogeneity with recharge. They should give the same results. I cannot find that back. Where did we put that? And do we want to keep StripAreaSink alive for the same reasons it was only implemented as an inhom with recharge in TTim? |
- label section comparing areasink to inhom areasink solutions. - add deprecation warning that XsectionAreaSink is for testing purposes only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply changes from TTim Xsections to TimML to keep the two as similar as possible: