Skip to content
This repository has been archived by the owner on Jul 17, 2022. It is now read-only.

Please remove global CSS styles from #28

Closed
icebob opened this issue Jun 26, 2017 · 4 comments
Closed

Please remove global CSS styles from #28

icebob opened this issue Jun 26, 2017 · 4 comments

Comments

@icebob
Copy link

icebob commented Jun 26, 2017

Hi,

great lib, but contains some global CSS styles, which changes my site design if I use it.

html {
  -webkit-box-sizing: border-box;
  -moz-box-sizing: border-box;
  box-sizing: border-box;
  -o-box-sizing: border-box;
  -ms-box-sizing: border-box;
  font-size: 62.5%; }

*, *:before, *:after {
  box-sizing: inherit; }

I think it is not need to use this lib.
Btw, it would be good to extract styles to a CSS file.

@mazipan
Copy link
Owner

mazipan commented Jun 26, 2017

Yes, I added these Global CSS for fix icon composition.
Maybe I can find solution for better icon css that currently modified from SweetAlert CSS.
Do you have any idea, which CSS that break your design @icebob ?

@icebob
Copy link
Author

icebob commented Jun 26, 2017

Yes, the font-size: 62.5%; in html break my design. The fonts will be very small.

@mazipan
Copy link
Owner

mazipan commented Jun 26, 2017

FYI : Your Pull-Request are always welcome.
Now, in Indonesia I have in holiday.
So, this issue will need time to solved.
Maybe you can tweak the code, and sent me Pull-Request

@mazipan
Copy link
Owner

mazipan commented Jun 26, 2017

I added font-size: 62.5%; for using rem unit.
Maybe we can remove it, I think

mazipan pushed a commit that referenced this issue Jul 3, 2017
+ remove font-size
+ update version
@mazipan mazipan closed this as completed Jul 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants