Skip to content
This repository was archived by the owner on Aug 19, 2024. It is now read-only.

Conversation

jefrydco
Copy link
Contributor

@jefrydco jefrydco commented Nov 20, 2019

Besides migrating to typescript, this PR also introduces modularized filters so that they can be
imported individually

Closes #33
Closes #35
Closes #36

@codecov-io
Copy link

codecov-io commented Nov 20, 2019

Codecov Report

Merging #78 into master will increase coverage by 7.4%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #78     +/-   ##
=======================================
+ Coverage   92.59%   100%   +7.4%     
=======================================
  Files           1      1             
  Lines          27     28      +1     
  Branches        2      0      -2     
=======================================
+ Hits           25     28      +3     
+ Misses          2      0      -2
Impacted Files Coverage Δ
lib/vue-string-filter.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f583afd...073cfd2. Read the comment docs.

@mazipan
Copy link
Owner

mazipan commented Nov 26, 2019

Conflict @jefrydco

Besides migrating to typescript, this PR also introduces modularized filters so that they can be
imported individually

Closes #33 #35 #36
@jefrydco
Copy link
Contributor Author

Resolved @mazipan

@mazipan mazipan merged commit 1f2ff80 into mazipan:master Nov 26, 2019
@jefrydco jefrydco deleted the feat/ts branch November 26, 2019 09:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to Typescript Better tree-shaking plan It is recommended to add a TypeScript language declaration file
3 participants