Skip to content
This repository was archived by the owner on Aug 19, 2024. It is now read-only.

Conversation

kazazes
Copy link
Contributor

@kazazes kazazes commented Jul 1, 2020

Neither Vue plugin typings nor nested module imports are currently working. Repro

Fixed the typings and added named imports on the root module (implicit subpath imports aren't supported by ECMA anyway).

@auto-comment
Copy link

auto-comment bot commented Jul 1, 2020

Thank you for raising your pull request. Please make sure you have followed @mazipan And please push ⭐ button in this repository

@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2020

Codecov Report

Merging #159 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #159   +/-   ##
=======================================
  Coverage   86.81%   86.81%           
=======================================
  Files          14       14           
  Lines          91       91           
  Branches       15       15           
=======================================
  Hits           79       79           
  Misses         12       12           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18b2700...58e205c. Read the comment docs.

@kazazes
Copy link
Contributor Author

kazazes commented Jul 1, 2020

Ahh looks like the CI demo build is overwriting new out path. I'll change it to demo.

Copy link
Owner

@mazipan mazipan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@mazipan mazipan merged commit 5dfeac8 into mazipan:master Jul 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants