Apply updates suggested in PR comment #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyladan
commented
Jan 17, 2020
| @@ -3,5 +3,5 @@ | |||
| const execSync = require('child_process').execSync; | |||
| const exec = cmd => execSync(cmd, { stdio: [0, 1, 2] }); | |||
|
|
|||
| exec('node benchmark/tracer'); | |||
| exec('node benchmark/propagator'); | |||
| exec('node benchmark/tracer.js'); | |||
There was a problem hiding this comment.
This fixes the issue oliver was talking about
| @@ -1,7 +1,7 @@ | |||
| 'use strict'; | |||
|
|
|||
| const benchmark = require('./benchmark'); | |||
| const opentelemetry = require('@opentelemetry/core'); | |||
| const opentelemetry = require('../packages/opentelemetry-core'); | |||
There was a problem hiding this comment.
Loading by filepath removes dependency management issues and ensures you're testing the current checked out branch
| @@ -26,7 +26,7 @@ const setups = [ | |||
| for (const setup of setups) { | |||
| console.log(`Beginning ${setup.name} Benchmark...`); | |||
| const propagator = setup.propagator; | |||
| const suite = benchmark() | |||
| const suite = benchmark(100) | |||
There was a problem hiding this comment.
formatters are fast so we can run them more times
|
|
||
| const exporter = new InMemorySpanExporter(); | ||
| const logger = new opentelemetry.NoopLogger(); | ||
|
|
||
| const setups = [ |
There was a problem hiding this comment.
I think these setups make more sense since Basic and Node TracerRegistries return the same Tracer class so their performance should be identical.
| registry: getRegistry(new BatchSpanProcessor(new InMemorySpanExporter())) | ||
| }, | ||
| { | ||
| name: 'NoopTracerRegistry', |
| const tracer = registry.getTracer("benchmark"); | ||
| const suite = benchmark() | ||
| const tracer = setup.registry.getTracer("benchmark"); | ||
| const suite = benchmark(20) |
There was a problem hiding this comment.
The tracer tests run slower so I did fewer runs. feel free to tweak it
mayurkale22
approved these changes
Jan 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making this into your branch so you can see what you think.