Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check-integrity to task settings tab #693

Merged
merged 1 commit into from
Jan 6, 2023
Merged

Add check-integrity to task settings tab #693

merged 1 commit into from
Jan 6, 2023

Conversation

raytrap
Copy link
Contributor

@raytrap raytrap commented Jan 4, 2023

Being able to adjust this setting on per-task basis allows to create a task for existing partially downloaded torrent or force verification on a seeding torrent file. Also, it looks like aria2 handles change to this setting nicely in any state so there is no apparent need to limit changeability to certain task states.

@mayswind
Copy link
Owner

mayswind commented Jan 5, 2023

I think the category should be "global" instead of "bittorrent", because this options does not only affect bittorrent download but also the http download with checksum option.

@raytrap
Copy link
Contributor Author

raytrap commented Jan 5, 2023

That's reasonable, I just wanted to play it safe. Pushing it to global would also make it easier to access.

@mayswind
Copy link
Owner

mayswind commented Jan 6, 2023

lgtm

@mayswind mayswind merged commit c1b6b2a into mayswind:master Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants