Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install packer for CI #77

Merged
merged 2 commits into from
Oct 20, 2017
Merged

Install packer for CI #77

merged 2 commits into from
Oct 20, 2017

Conversation

fuzzmz
Copy link
Contributor

@fuzzmz fuzzmz commented Oct 17, 2017

Issue

Fixes #63

List of Changes Proposed

Add a bash script which downloads the latest available version of Packer and unzips it.

Testing Evidence

Not yet tested. Need to check if the CI environment has the tools required by the shell script.

@fuzzmz
Copy link
Contributor Author

fuzzmz commented Oct 17, 2017

Strange, looks like GitHub doesn't want to see the change I did to make the get-packer.sh script executable. Going to give it a bit more time, and if it still doesn't catch it we have two options:

  1. close this PR and open a new one;
  2. update the build configs to make the file executable there.

I'd honestly go with the first option, as it's cleaner than adding additional stuff in the build configs, but what do you say?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.944% when pulling 274799a on fuzzmz:install-packer-for-ci into 48bff8e on mayn:master.

@fuzzmz fuzzmz force-pushed the install-packer-for-ci branch from 274799a to 92519a5 Compare October 17, 2017 18:02
@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.944% when pulling 92519a5 on fuzzmz:install-packer-for-ci into 48bff8e on mayn:master.

@fuzzmz
Copy link
Contributor Author

fuzzmz commented Oct 17, 2017

OK, now we get packer on Travis CI in the build workspace.

Going to add a powershell script to download it for Appveyor tomorrow since at home I don't have access to a Windows machine.

@mayn
Copy link
Owner

mayn commented Oct 17, 2017

@fuzzmz this is awesome!
minor comment can we move these scripts to a tools folder when ready.

Thanks again.

@fuzzmz
Copy link
Contributor Author

fuzzmz commented Oct 18, 2017

Sure thing.

@fuzzmz fuzzmz force-pushed the install-packer-for-ci branch from 92519a5 to 1ec4716 Compare October 18, 2017 07:33
@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.944% when pulling 1ec4716 on fuzzmz:install-packer-for-ci into cfb5c3f on mayn:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.944% when pulling daa72cf on fuzzmz:install-packer-for-ci into cfb5c3f on mayn:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.944% when pulling 7f5cee0 on fuzzmz:install-packer-for-ci into cfb5c3f on mayn:master.

@fuzzmz fuzzmz force-pushed the install-packer-for-ci branch from 7f5cee0 to 2ad7aa7 Compare October 18, 2017 09:34
@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.944% when pulling 2ad7aa7 on fuzzmz:install-packer-for-ci into cfb5c3f on mayn:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.944% when pulling 394eb1c on fuzzmz:install-packer-for-ci into cfb5c3f on mayn:master.

@fuzzmz
Copy link
Contributor Author

fuzzmz commented Oct 18, 2017

@mayn, any chance you can cancel the AppVeyor builds for this branch except for the "add debug messages" one? Looks like the powershell script fails somewhere and doesn't give any output, and it takes 1 hour for a job to timeout (and with 6 jobs per build, with another build queued which might not pass, it'll take ages to test this).

@mayn
Copy link
Owner

mayn commented Oct 18, 2017

@fuzzmz done. I wonder if there is an appveyor setting you can inject into your branch to timeout faster?

@fuzzmz
Copy link
Contributor Author

fuzzmz commented Oct 18, 2017

Awesome, thanks!

@fuzzmz fuzzmz force-pushed the install-packer-for-ci branch from 394eb1c to d1d8341 Compare October 18, 2017 13:47
@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.944% when pulling d1d8341 on fuzzmz:install-packer-for-ci into cfb5c3f on mayn:master.

@fuzzmz
Copy link
Contributor Author

fuzzmz commented Oct 18, 2017

@mayn, can you also cancel these running builds? Have a final version tested it on my own instance of Appveyor which should be good to go.

Sorry for all the fuss, don't know why I didn't think of enabling integration with Appveyor with my own fork until now.

Add bash script to download and unzip the latest
available version of Packer.

It parses the versions available at
https://releases.hashicorp.com/packer/ and gets
the linux amd64 archive.
Add powershell script to download and unzip the
latest available version of Packer.

It parses the versions available at
https://releases.hashicorp.com/packer/ and gets
the Windows amd64 archive.
@fuzzmz
Copy link
Contributor Author

fuzzmz commented Oct 18, 2017

OK, have to run from work so I'll push the final commits now. With this change everything seems to be working.

Until your build which doesn't work times out you can see the working build result in my instance of Appveyor here.

@fuzzmz fuzzmz force-pushed the install-packer-for-ci branch from d1d8341 to 1c1bad3 Compare October 18, 2017 14:21
@fuzzmz fuzzmz changed the title [WIP] Install packer for CI Install packer for CI Oct 18, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.944% when pulling 1c1bad3 on fuzzmz:install-packer-for-ci into cfb5c3f on mayn:master.

@mayn mayn closed this Oct 18, 2017
@mayn mayn reopened this Oct 18, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.944% when pulling 1c1bad3 on fuzzmz:install-packer-for-ci into cfb5c3f on mayn:master.

@fuzzmz
Copy link
Contributor Author

fuzzmz commented Oct 19, 2017

This is pretty much done from my point of view. Any feedback?

@mayn
Copy link
Owner

mayn commented Oct 19, 2017

@fuzzmz thanks. Will review/merge later today

Copy link
Owner

@mayn mayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mayn mayn added this to the 0.6.0 milestone Oct 20, 2017
@mayn mayn merged commit 73a561a into mayn:master Oct 20, 2017
@fuzzmz fuzzmz deleted the install-packer-for-ci branch October 20, 2017 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants