-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install packer for CI #77
Conversation
Strange, looks like GitHub doesn't want to see the change I did to make the
I'd honestly go with the first option, as it's cleaner than adding additional stuff in the build configs, but what do you say? |
274799a
to
92519a5
Compare
OK, now we get packer on Travis CI in the build workspace. Going to add a powershell script to download it for Appveyor tomorrow since at home I don't have access to a Windows machine. |
@fuzzmz this is awesome! Thanks again. |
Sure thing. |
92519a5
to
1ec4716
Compare
7f5cee0
to
2ad7aa7
Compare
@mayn, any chance you can cancel the AppVeyor builds for this branch except for the "add debug messages" one? Looks like the powershell script fails somewhere and doesn't give any output, and it takes 1 hour for a job to timeout (and with 6 jobs per build, with another build queued which might not pass, it'll take ages to test this). |
@fuzzmz done. I wonder if there is an appveyor setting you can inject into your branch to timeout faster? |
Awesome, thanks! |
394eb1c
to
d1d8341
Compare
@mayn, can you also cancel these running builds? Have a final version tested it on my own instance of Appveyor which should be good to go. Sorry for all the fuss, don't know why I didn't think of enabling integration with Appveyor with my own fork until now. |
Add bash script to download and unzip the latest available version of Packer. It parses the versions available at https://releases.hashicorp.com/packer/ and gets the linux amd64 archive.
Add powershell script to download and unzip the latest available version of Packer. It parses the versions available at https://releases.hashicorp.com/packer/ and gets the Windows amd64 archive.
OK, have to run from work so I'll push the final commits now. With this change everything seems to be working. Until your build which doesn't work times out you can see the working build result in my instance of Appveyor here. |
d1d8341
to
1c1bad3
Compare
This is pretty much done from my point of view. Any feedback? |
@fuzzmz thanks. Will review/merge later today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue
Fixes #63
List of Changes Proposed
Add a bash script which downloads the latest available version of Packer and unzips it.
Testing Evidence
Not yet tested. Need to check if the CI environment has the tools required by the shell script.