Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove duplicate keys from builders #61

Merged
merged 1 commit into from
Oct 13, 2017
Merged

remove duplicate keys from builders #61

merged 1 commit into from
Oct 13, 2017

Conversation

mprince
Copy link
Contributor

@mprince mprince commented Oct 13, 2017 •
edited
Loading

Description

remove duplicate keys from builders

Testing

tox results

 108 passed, 1 skipped in 2.02 seconds

@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.746% when pulling 2727dd8 on mprince:duplicate into 3805009 on mayn:master.

mayn
mayn approved these changes Oct 13, 2017
View reviewed changes
Copy link
Owner

@mayn mayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mayn mayn added the bug label Oct 13, 2017
@mayn mayn added this to the 0.5.0 milestone Oct 13, 2017
@mayn mayn merged commit 44e71b4 into mayn:master Oct 13, 2017
@mprince mprince deleted the duplicate branch October 13, 2017 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayn mayn mayn approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mprince @coveralls @mayn