Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added pull request template #47

Merged
merged 1 commit into from
Oct 12, 2017
Merged

Added pull request template #47

merged 1 commit into from
Oct 12, 2017

Conversation

anurag-ks
Copy link
Contributor

Issue Addressed
#46

@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.637% when pulling 50b5c0d on anurag-ks:master into 75cb7db on mayn:master.

mayn
mayn requested changes Oct 12, 2017
View reviewed changes
.github/PULL_REQUEST_TEMPLATE.md Outdated

## List of Changes Proposed

*
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove this *

.github/PULL_REQUEST_TEMPLATE.md Outdated
## Testing
Specify the steps to test or reproduce the PR

````sh
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this example

@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.692% when pulling 7973df2 on anurag-ks:master into fce572e on mayn:master.

@anurag-ks
Copy link
Contributor Author

@mayn done.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.692% when pulling 9d70a2d on anurag-ks:master into fce572e on mayn:master.

@mayn mayn added this to the 0.5.0 milestone Oct 12, 2017
@mayn
Copy link
Owner

mayn commented Oct 12, 2017

thanks @anurag-ks !

@mayn mayn merged commit 632b5b8 into mayn:master Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayn mayn mayn approved these changes

Assignees
No one assigned
Labels
pr/needs-changes
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anurag-ks @coveralls @mayn