Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated builder test to cover passing a list of builder values #34

Merged
merged 1 commit into from
Oct 9, 2017
Merged

updated builder test to cover passing a list of builder values #34

merged 1 commit into from
Oct 9, 2017

Conversation

codevbus
Copy link
Contributor

@codevbus codevbus commented Oct 9, 2017 •
edited by mayn
Loading

issue #18
Increased coverage in template.py by passing a list of builder values vs. a single builder in the test.

@codevbus codevbus mentioned this pull request Oct 9, 2017
Closed
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 81.456% when pulling 2043695 on codevbus:increase_coverage_in_test_template into cadbc2a on mayn:master.

mayn
mayn approved these changes Oct 9, 2017
View reviewed changes
Copy link
Owner

@mayn mayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks!

@mayn mayn merged commit c8399fa into mayn:master Oct 9, 2017
@mayn mayn added this to the 0.5.0 milestone Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayn mayn mayn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@codevbus @coveralls @mayn