Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making run_command take a list of strings instead of a single string #137

Merged
merged 1 commit into from
Oct 13, 2018
Merged

Making run_command take a list of strings instead of a single string #137

merged 1 commit into from
Oct 13, 2018

Conversation

gnewson
Copy link
Contributor

@gnewson gnewson commented Oct 13, 2018

Issue

#133

List of Changes Proposed

Change a string to a list of strings as per issue 133

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 0d152eb on gnewson:issue_133 into 8c8471c on mayn:master.

@mayn mayn added this to the 1.0.2 milestone Oct 13, 2018
@mayn mayn merged commit 520dc57 into mayn:master Oct 13, 2018
mayn added a commit that referenced this pull request Oct 13, 2018
@mayn
Merge pull request #137 from gnewson/issue_133
8cc21f3 
fixes #133 builders/Docker run_command should accept a list of strings
@gnewson gnewson deleted the issue_133 branch October 14, 2018 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug builder
Projects
None yet
Milestone
1.0.2
Development

Successfully merging this pull request may close these issues.
3 participants
@gnewson @coveralls @mayn