Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shutdown_behavior #122

Closed
levisbakalinsky opened this issue Sep 21, 2018 · 2 comments · Fixed by #134
Closed

shutdown_behavior #122

levisbakalinsky opened this issue Sep 21, 2018 · 2 comments · Fixed by #134
Labels
awaiting-reply hey! get back to me on this bug builder
Milestone
1.0.2

Comments

@levisbakalinsky
Copy link
Contributor

packerlicious version

Packerlicious: 1.0.1
Packer: 1.3.0

Expected behavior

shutdown_behavior="terminate" should have passed validation and not thrown an error. Packer expects "terminate" not ["terminate"]

Actual behavior

shutdown_behavior="terminate",
TypeError: <class 'packerlicious.builder.AmazonEbs'>: None.shutdown_behavior is <type 'str'>, expected [<type 'str'>]

Steps to reproduce

Set shutdown_behavior="terminate",
@levisbakalinsky levisbakalinsky mentioned this issue Sep 21, 2018
Merged
@levisbakalinsky
Copy link
Contributor Author

See this page for formatting. Looked through packer change log, but haven't found if they recently changed the format.

https://www.packer.io/docs/builders/amazon-ebs.html#shutdown_behavior

@mayn mayn added this to the 1.0.2 milestone Sep 24, 2018
@mayn mayn added the awaiting-reply hey! get back to me on this label Oct 1, 2018
mayn added a commit that referenced this issue Oct 11, 2018
@mayn
#122 correct shutdown_behavior type for remaining Amazon resources
1098a1c
@mayn mayn mentioned this issue Oct 11, 2018
Merged
@mayn mayn closed this as completed in #134 Oct 11, 2018
mayn added a commit that referenced this issue Oct 11, 2018
@mayn
Merge pull request #134 from mayn/issue-122
8c8471c 
#122 correct shutdown_behavior type for AmazonEbsSurrogate and AmazonEbsVolume
mayn added a commit that referenced this issue Oct 13, 2018
@mayn
Merge pull request #134 from mayn/issue-122
b9516e9 
#122 correct shutdown_behavior type for AmazonEbsSurrogate and AmazonEbsVolume
mayn added a commit that referenced this issue Oct 13, 2018
@mayn
#122 correct shutdown_behavior type for remaining Amazon resources
22372dc
@mayn
Copy link
Owner

mayn commented Oct 13, 2018

@levisbakalinsky v1.0.2 was released w/ this change. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
awaiting-reply hey! get back to me on this bug builder
Projects
None yet
Milestone
1.0.2
Development

Successfully merging a pull request may close this issue.

#122 correct shutdown_behavior type for AmazonEbsSurrogate and AmazonEbsVolume mayn/packerlicious
2 participants
@mayn @levisbakalinsky