bump zgw-consumers to 0.35.1, commonground-api-common to 2.0.1, OAF to 0.9.0 #33
Conversation
…commonground-api-common to 2.0.1, OAF to 0.9.0
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #33 +/- ##
==========================================
- Coverage 92.50% 92.44% -0.06%
==========================================
Files 54 54
Lines 1054 1046 -8
==========================================
- Hits 975 967 -8
Misses 79 79 ☔ View full report in Codecov by Sentry. |
Dockerfile
Outdated
| @@ -11,7 +11,7 @@ RUN apt-get update && apt-get upgrade -y && apt-get install -y --no-install-reco | |||
| pkg-config \ | |||
| build-essential \ | |||
| # only relevant when using editable/github dependencies, which is discouraged | |||
| # git \ | |||
| git \ | |||
There was a problem hiding this comment.
This should be reverted whenever a new release happens for commonground-api-common/ OAF.
requirements/base.in
Outdated
| @@ -1,3 +1,4 @@ | |||
| open-api-framework | |||
| git+https://github.com/maykinmedia/commonground-api-common.git@issue/44-migration-error | |||
There was a problem hiding this comment.
Like the comment above, adding a reminder here that this should be pinned to a release version. We probably also want to get rid of pinning commonground-api-common in all the projects and pulling that dependency in through OAF, see discussion.
There was a problem hiding this comment.
could you make a separate issue to bump commonground-api-common in OAF and upgrade OAF for all components?
There was a problem hiding this comment.
fixes maykinmedia/open-api-framework#66
depends on maykinmedia/commonground-api-common#45