Skip to content

Commit

Permalink
🎨 activated files change check in test workflow
Browse files Browse the repository at this point in the history
  • Loading branch information
bart-maykin committed May 10, 2024
1 parent 7bab4d5 commit 2d0c1af
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 13 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,11 @@ jobs:

tests:
runs-on: ubuntu-latest
# needs:
# - changed-files
needs:
- changed-files

# # only run tests if source files have changed (e.g. skip for PRs that only update docs)
# if: ${{ needs.changed-files.outputs.changed-py-files == 'true'|| needs.changed-files.outputs.changed-requirements == 'true'|| github.event_name == 'push' }}
# only run tests if source files have changed (e.g. skip for PRs that only update docs)
if: ${{ needs.changed-files.outputs.changed-py-files == 'true'|| needs.changed-files.outputs.changed-requirements == 'true'|| github.event_name == 'push' }}

strategy:
matrix:
Expand Down
4 changes: 1 addition & 3 deletions src/referentielijsten/api/filterset.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,7 @@ class ItemFilterset(FilterSet):
method="filter_is_geldig",
)
tabel__code = filters.CharFilter(
help_text=_(
"De waarde van de `tabel__code` die gelinkt is aan de items: VERPLICHT"
),
help_text=_("De waarde van de `tabel__code` die gelinkt is aan de items."),
required=True,
)

Expand Down
2 changes: 0 additions & 2 deletions src/referentielijsten/api/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -95,14 +95,12 @@ class Item(models.Model):
begindatum_geldigheid = models.DateTimeField(
_("begindatum geldigheid"),
help_text=_("De datum vanaf waneer deze tabel geldig is."),
editable=True,
blank=True,
null=True,
)
einddatum_geldigheid = models.DateTimeField(
_("einddatum geldigheid"),
help_text=_("De datum tot wanneer deze tabel geldig is."),
editable=True,
blank=True,
null=True,
)
Expand Down
3 changes: 1 addition & 2 deletions src/referentielijsten/api/openapi.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,7 @@ paths:
name: tabel__code
schema:
type: string
description: 'De waarde van de `tabel__code` die gelinkt is aan de items:
VERPLICHT'
description: De waarde van de `tabel__code` die gelinkt is aan de items.
required: true
tags:
- items
Expand Down
1 change: 0 additions & 1 deletion src/referentielijsten/conf/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@
# Optional applications.
"ordered_model",
"django_admin_index",
"django_jsonform",
"django.contrib.admin",
# 'django.contrib.admindocs',
# 'django.contrib.humanize',
Expand Down
1 change: 0 additions & 1 deletion src/referentielijsten/js/components/nav/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ class TabNav {
}

setActive(tabButton) {
console.log("tabNode=", tabButton);
// make inactive all tabs and contents
this.tabButtons.forEach((btn) => {
btn.classList.remove("nav__item--active");
Expand Down

0 comments on commit 2d0c1af

Please sign in to comment.