✨ [#234] Validate DigitaalAdres.adres if type is email #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SonnyBA
requested changes
Oct 18, 2024
| @@ -90,6 +92,54 @@ def test_create_digitaal_adres(self): | |||
| self.assertEqual(data["adres"], "foobar@example.com") | |||
| self.assertEqual(data["omschrijving"], "omschrijving") | |||
|
|
|||
| def test_create_digitaal_adres_email_validation(self): | |||
There was a problem hiding this comment.
Could you also add a test which verifies that whenever SoortPartij is not email no email validation is done?
There was a problem hiding this comment.
This is already tested as part of test_update_digitaal_adres which uses SoortDigitaalAdres.telefoonnummer, is that enough or should I add a separate test case for it?
| @@ -85,6 +88,7 @@ class Meta: | |||
| "help_text": _("De unieke URL van dit digitaal adres binnen deze API."), | |||
| }, | |||
| } | |||
| validators = [OptionalEmailValidator()] | |||
There was a problem hiding this comment.
It would be nice if this validation is also done in the admin (not only through the API).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #234
Changes