[#232] use an enum for soortDigitaalAdres
#270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SonnyBA
force-pushed
the
issue/#232-add-soort-digitaal-adres-enum
branch
from
cf324a2
to
1b1a721
Compare
stevenbal
requested changes
Oct 18, 2024
...lant/components/klantinteracties/migrations/0020_alter_digitaaladres_soort_digitaal_adres.py
Show resolved
Hide resolved
| @@ -36,6 +37,7 @@ class DigitaalAdres(APIMixin, models.Model): | |||
| "met dit adres contact kan worden opgenomen." | |||
| ), | |||
| max_length=255, | |||
| choices=SoortDigitaalAdres.choices, | |||
There was a problem hiding this comment.
The issue also mentions:
Add an 'overig' (other) option with the option to add a custom type of digital address.
So we might have to add an extra field in which this custom type can be specified?
There was a problem hiding this comment.
Might be because of the wording but I think it refers to having an overig option to allow the adres field to contain other values than that of the email/telefoonnummer types.
stevenbal
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #232
Changes
Changes allowed values for
soortDigitaalAdresto be one ofemail,telefoonnummeroroverig