Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ [#147] Convenience endpoint for Klantcontact/Betrokkene/Onderwerpobject #260

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

✨ [#147] Convenience endpoint for Klantcontact/Betrokkene/Onderwerpobject #260

wants to merge 6 commits into from

Commits on Oct 18, 2024

  1. 🐛 Fix incorrect viewname for onderwerpobject URL attribute 

    previously this used the Klantcontact view, causing incorrect URLs to appear in the detail response for the Onderwerpobject endpoint
    @stevenbal
    stevenbal committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    abec9a7 View commit details
    Browse the repository at this point in the history

  2. ✨ [#147] Convenience endpoint for Klantcontact/Betrokkene/Onderwerpob… 

    …ject

to allow creation of these three resources in a single API call
    @stevenbal
    stevenbal committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    c4664f6 View commit details
    Browse the repository at this point in the history

  3. ✅ [#147] Add tests for convenience endpoint

    @stevenbal
    stevenbal committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    2483b95 View commit details
    Browse the repository at this point in the history

  4. 🏷️ Add typehints to remove redoc warnings

    @stevenbal
    stevenbal committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    74b50b2 View commit details
    Browse the repository at this point in the history

  5. ♻️ [#147] Make Betrokkene and OnderwerpObject optional in convenience… 

    … endpoint

because it should be possible to create e.g.:
- a KlantContact with a Betrokkene but no OnderwerpObject
- a KlantContact with an OnderwerpObject but no Betrokkene
    @stevenbal
    stevenbal committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    13203d1 View commit details
    Browse the repository at this point in the history

  6. 👌 [#147] PR feedback

    @stevenbal
    stevenbal committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    ba76269 View commit details
    Browse the repository at this point in the history