🔧[maykinmedia/open-api-framework#68] fix CSP errors #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coperh
requested review from
SonnyBA,
bart-maykin and
stevenbal
and removed request for
SonnyBA
Coperh
force-pushed
the
feature/oaf-68-csp-errors
branch
from
e047c40
to
40f6ff7
Compare
annashamray
reviewed
Oct 1, 2024
.github/workflows/oaf-check.yml
Outdated
| @@ -0,0 +1,17 @@ | |||
| name: Check Open API Framework Version | |||
There was a problem hiding this comment.
It looks like this CI check is not in the scope of the bugfix
There was a problem hiding this comment.
This is what happens when you test new features in a random project.
.github/workflows/oaf-check.yml
Outdated
| branches: [ "master" ] | ||
| pull_request: | ||
| # The branches below must be a subset of the branches above | ||
| branches: [ "master" ] |
There was a problem hiding this comment.
afair we've decided to include all branches for the CI
But it could be moved to the separate PR
There was a problem hiding this comment.
Yeah, this is an old test version. The up-to-date version is in objects API
Coperh
force-pushed
the
feature/oaf-68-csp-errors
branch
from
40f6ff7
to
f18c0b0
Compare
stevenbal
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes maykinmedia/open-api-framework#68