[#2821] Implement provisional configuration for OpenKlant2 service #1452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi-sigma
force-pushed
the
task/2821-openklant2-config
branch
from
eea4282
to
ac0385b
Compare
pi-sigma
changed the title
pi-sigma
force-pushed
the
task/2821-openklant2-config
branch
2 times, most recently
from
2a144b4
to
76c93ec
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1452 +/- ##
===========================================
- Coverage 94.58% 94.57% -0.01%
===========================================
Files 1061 1061
Lines 39627 39659 +32
===========================================
+ Hits 37481 37508 +27
- Misses 2146 2151 +5 ☔ View full report in Codecov by Sentry. |
swrichards
requested changes
Oct 21, 2024
src/openklant2/models.py
Outdated
There was a problem hiding this comment.
As discussed: this should be in open_inwoner.openklant -- it's domain specific.
pi-sigma
force-pushed
the
task/2821-openklant2-config
branch
from
76c93ec
to
086aa0b
Compare
swrichards
requested changes
Oct 22, 2024
pi-sigma
force-pushed
the
task/2821-openklant2-config
branch
from
086aa0b
to
3402ea1
Compare
pi-sigma
force-pushed
the
task/2821-openklant2-config
branch
from
3402ea1
to
8968133
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds a provisional configuration for the OpenKlant2 service + tests so we can start integrating OpenKlant2 into our code. To be replaced with a proper configuration model.
Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/task/2821