product conditions #121
Merged
product conditions #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annashamray
force-pushed
the
feature/product-conditions
branch
from
ea11033
to
bc58739
Compare
alextreme
reviewed
Feb 23, 2022
alextreme
reviewed
Feb 23, 2022
|
2 minor comments but all in all this is a fine first step with the conditions. Nice! |
alextreme
approved these changes
Feb 23, 2022
|
Can be merged once you're ready |
annashamray
force-pushed
the
feature/product-conditions
branch
from
5df0a3b
to
4383780
Compare
JostCrow
pushed a commit
that referenced
this pull request
May 4, 2022
* ✨ #121 - Login page. * 🙈 - Update .gitignore. * ✨ - Login page improvements. * 👕 - black. * 👕 - isort. * 👌 - Please add all the options that someone can pass through. So that we don't have to scan the template. * 👌 - I think that it will be better to split the cards. Since they now serve multiple purposes and are getting complicated. * 👌 - Why is the slash added? * 👌 - Please add all the options that someone can pass through. So that we don't have to scan the template. * 👌 - Please add all the options that someone can pass through. So that we don't have to scan the template. * 👌 - If we are going to support reverse you should be able to also pass the reverse kwargs. Otherwise, please revert. * 👌 - Also provide a way to add the hero image to a page without overwriting main_outer. * 👌 - Please reset this. Since this will break other pages. * 👕 - Black. * 💄 - Redesigned login page. * 👕 - Black. * 💄 - Make DigiD login bold.
alextreme
added a commit
that referenced
this pull request
Oct 15, 2024
pi-sigma
pushed a commit
that referenced
this pull request
Oct 18, 2024
pi-sigma
pushed a commit
that referenced
this pull request
Oct 22, 2024
pi-sigma
pushed a commit
that referenced
this pull request
Oct 22, 2024
pi-sigma
pushed a commit
that referenced
this pull request
Oct 22, 2024
alextreme
added a commit
that referenced
this pull request
Oct 22, 2024
[Venray #121] Support sorting the statusses on date set (Rx.mission, Open Zaak)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.