Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#390] Add OIDC #403

Merged
merged 20 commits into from
Oct 11, 2024
Merged

[#390] Add OIDC #403

merged 20 commits into from
Oct 11, 2024

Conversation

SilviaAmAm
Copy link
Collaborator

@SilviaAmAm SilviaAmAm commented Oct 2, 2024 •
edited
Loading

Fixes #390

@SilviaAmAm SilviaAmAm marked this pull request as draft October 2, 2024 15:16
@SilviaAmAm SilviaAmAm mentioned this pull request Oct 2, 2024
Closed
7 tasks
@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 54.22535% with 65 lines in your changes missing coverage. Please review.

Project coverage is 78.00%. Comparing base (11154b9) to head (cee7ae8).

Files with missing lines Patch % Lines
.../src/openarchiefbeheer/api/tests/test_oidc_auth.py 19.23% 42 Missing ⚠️
frontend/src/pages/login/Login.tsx 0.00% 10 Missing and 1 partial ⚠️
frontend/src/pages/login/Login.stories.tsx 0.00% 8 Missing ⚠️
frontend/src/lib/api/auth.ts 50.00% 2 Missing ⚠️
backend/src/openarchiefbeheer/utils/tests/e2e.py 80.00% 1 Missing ⚠️
frontend/src/App.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #403      +/-   ##
==========================================
- Coverage   78.43%   78.00%   -0.43%     
==========================================
  Files         253      256       +3     
  Lines        7998     8138     +140     
  Branches      169      170       +1     
==========================================
+ Hits         6273     6348      +75     
- Misses       1575     1639      +64     
- Partials      150      151       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SilviaAmAm SilviaAmAm force-pushed the feature/390-add-oidc-backend branch 8 times, most recently from b34b306 to 79be539 Compare October 8, 2024 10:23
@SilviaAmAm SilviaAmAm changed the title [#390] Add OIDC backend [#390] Add OIDC Oct 9, 2024
@SilviaAmAm SilviaAmAm marked this pull request as ready for review October 9, 2024 08:58
svenvandescheur
svenvandescheur requested changes Oct 10, 2024
View reviewed changes
backend/docker-services/keycloak/docker-compose.yaml Show resolved Hide resolved
frontend/src/App.tsx Outdated Show resolved Hide resolved
frontend/src/lib/contexts/ExtraConfigContext.ts Outdated Show resolved Hide resolved
svenvandescheur
svenvandescheur approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@svenvandescheur svenvandescheur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix banner in docker-compose.yml

@SilviaAmAm SilviaAmAm merged commit b3a214d into main Oct 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svenvandescheur svenvandescheur svenvandescheur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OIDC koppeling maken
3 participants
@SilviaAmAm @codecov-commenter @svenvandescheur