Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out how to configure Nginx to deal with frontend navigation [DevOps] #169

Closed
SilviaAmAm opened this issue Jul 8, 2024 · 0 comments · Fixed by #170
Closed

Figure out how to configure Nginx to deal with frontend navigation [DevOps] #169

SilviaAmAm opened this issue Jul 8, 2024 · 0 comments · Fixed by #170
Assignees
@SilviaAmAm
Labels
bug Something isn't working

Comments

@SilviaAmAm
Copy link
Collaborator

Currently, when a reviewer navigates to a destruction list detail page, a GET call is made to destruction-lists/48937b33-e9fb-4918-97e9-64a3ae9a96a1/review

However, this is not a backend route, just a frontend one. So we get a 404.
@SilviaAmAm SilviaAmAm added the bug Something isn't working label Jul 8, 2024
@SilviaAmAm SilviaAmAm self-assigned this Jul 8, 2024
SilviaAmAm added a commit that referenced this issue Jul 8, 2024
@SilviaAmAm
🐛 [#169] Let react-router handle routes of single page app
426c4e5 
In the docs of React Router: https://reactrouter.com/en/6.24.1/routers/picking-a-router#web-projects
> If you're hosting your app on a static file server, you'll need to configure it to send all requests to your index.html to avoid getting 404s.
@SilviaAmAm SilviaAmAm mentioned this issue Jul 8, 2024
Merged
SilviaAmAm added a commit to maykinmedia/charts that referenced this issue Jul 8, 2024
@SilviaAmAm
🐛 [maykinmedia/open-archiefbeheer#169] Let react-router handle routes…
a3a5971 
… of single page app

In the docs of React Router: https://reactrouter.com/en/6.24.1/routers/picking-a-router#web-projects

> If you're hosting your app on a static file server, you'll need to configure it to send all requests to your index.html to avoid getting 404s.
SilviaAmAm added a commit that referenced this issue Jul 8, 2024
@SilviaAmAm
Merge pull request #170 from maykinmedia/fix/nginx-spa-routing
6f74d81 
🐛 [#169] Let react-router handle routes of single page app
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SilviaAmAm SilviaAmAm

Labels
bug Something isn't working
Projects
Open Archiefbeheer - Sprints
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 [#169] Let react-router handle routes of single page app maykinmedia/open-archiefbeheer
1 participant
@SilviaAmAm