🚧 Debugging webkit tests

maykinmedia · Oct 7, 2024 · 44403fd · 44403fd
1 parent e405cd6
commit 44403fd
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -247,14 +247,14 @@ jobs:
           PLAYWRIGHT_BROWSER: ${{ matrix.browser }}
           PLAYWRIGHT_TRACE_PATH: ${{ matrix.browser }}-playwright-trace.zip
 
-      # # Uncomment if you are recording traces for debug purposes
-      # - uses: actions/upload-artifact@v4
-      #   if: ${{ failure() }}
-      #   with:
-      #     name: ${{ matrix.browser }}-playwright-trace.zip
-      #     path: ${{ github.workspace }}/backend/${{ matrix.browser }}-playwright-trace.zip
-      #     retention-days: 1
-      #     if-no-files-found: error
+      # Uncomment if you are recording traces for debug purposes
+      - uses: actions/upload-artifact@v4
+        if: ${{ failure() }}
+        with:
+          name: ${{ matrix.browser }}-playwright-trace.zip
+          path: ${{ github.workspace }}/backend/${{ matrix.browser }}-playwright-trace.zip
+          retention-days: 1
+          if-no-files-found: error
 
   docs:
    name: Build and check documentation

diff --git a/backend/src/openarchiefbeheer/api/tests/test_oidc_auth.py b/backend/src/openarchiefbeheer/api/tests/test_oidc_auth.py
@@ -2,7 +2,7 @@
 
 from playwright.async_api import expect
 
-from openarchiefbeheer.utils.tests.e2e import browser_page
+from openarchiefbeheer.utils.tests.e2e import browser_page, browser_page_with_tracing
 from openarchiefbeheer.utils.tests.gherkin import GherkinLikeTestCase
 
 
@@ -11,7 +11,7 @@ class OIDCLoginTest(GherkinLikeTestCase):
     fixtures = ["permissions.json", "oidc_config_test.json"]
 
     async def test_login_admin_superuser_with_oidc(self):
-        async with browser_page() as page:
+        async with browser_page_with_tracing() as page:
             await page.goto(f"{self.live_server_url}/admin")
 
             link = page.get_by_role("link", name="Login with OIDC")