Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/486 token permissions configuration #497

Merged
merged 8 commits into from
Dec 19, 2024

Conversation

danielmursa-dev
Copy link
Contributor

@danielmursa-dev danielmursa-dev commented Dec 17, 2024

Fixes #486

@danielmursa-dev danielmursa-dev changed the base branch from master to feature/485-token-permissions-setup-configuration December 18, 2024 10:14
Copy link
Contributor

@swrichards swrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor issues, but otherwise LGTM

src/objects/setup_configuration/steps/token_auth.py Outdated Show resolved Hide resolved
src/objects/setup_configuration/models/token_auth.py Outdated Show resolved Hide resolved
docker/setup_configuration/data.yaml Outdated Show resolved Hide resolved
src/objects/setup_configuration/steps/token_auth.py Outdated Show resolved Hide resolved
Base automatically changed from feature/485-token-permissions-setup-configuration to master December 19, 2024 10:30
author Daniel Mursa <daniel@maykinmedia.nl> 1734341658 +0100
committer Daniel Mursa <daniel@maykinmedia.nl> 1734604578 +0100

parent 64fa395
author Daniel Mursa <daniel@maykinmedia.nl> 1734341658 +0100
committer Daniel Mursa <daniel@maykinmedia.nl> 1734604572 +0100

[#485] Merge closed branch

[#485] Add SitesConfigurationStep and TokenAuthConfigurationStep in settings

[#485] Black and isort

[#485] Fix requirements

[#485] Update namespace

[#486] Update TokenAuthConfigurationStep

[#486] Permissions can be empty list

[#486] Update tests

[#486] New tests

[#486] Update tests

[#486] Fix old tests

[#486] Update data.yaml

[#486] Activate ObjectTypesConfigurationStep

[#486] Add new test

[#486] Update config_cli.rst

[#486] Fix config_cli.rst

[#486] Fix config_cli.rst

[#486] Uniform data.yaml and config_cli.rst
@danielmursa-dev danielmursa-dev force-pushed the feature/486-token-permissions-configuration branch from 5d874de to 02426aa Compare December 19, 2024 10:37
@danielmursa-dev danielmursa-dev merged commit 82a93b9 into master Dec 19, 2024
14 checks passed
@danielmursa-dev danielmursa-dev deleted the feature/486-token-permissions-configuration branch December 19, 2024 13:25
SonnyBA pushed a commit that referenced this pull request Jan 8, 2025
* parent 64fa395
author Daniel Mursa <daniel@maykinmedia.nl> 1734341658 +0100
committer Daniel Mursa <daniel@maykinmedia.nl> 1734604578 +0100

parent 64fa395
author Daniel Mursa <daniel@maykinmedia.nl> 1734341658 +0100
committer Daniel Mursa <daniel@maykinmedia.nl> 1734604572 +0100

[#485] Merge closed branch

[#485] Add SitesConfigurationStep and TokenAuthConfigurationStep in settings

[#485] Black and isort

[#485] Fix requirements

[#485] Update namespace

[#486] Update TokenAuthConfigurationStep

[#486] Permissions can be empty list

[#486] Update tests

[#486] New tests

[#486] Update tests

[#486] Fix old tests

[#486] Update data.yaml

[#486] Activate ObjectTypesConfigurationStep

[#486] Add new test

[#486] Update config_cli.rst

[#486] Fix config_cli.rst

[#486] Fix config_cli.rst

[#486] Uniform data.yaml and config_cli.rst

* [#486] Update PrerequisiteFailed in ConfigurationRunFailed

* [#486] Fields type in permissions

* [#486] Update debug message

* [#486] Update permissions fields type

* [#486] Fix tests

* [#486] New test for field_based_authorization

* [#486] Flake8
SonnyBA pushed a commit that referenced this pull request Jan 8, 2025
* parent 64fa395
author Daniel Mursa <daniel@maykinmedia.nl> 1734341658 +0100
committer Daniel Mursa <daniel@maykinmedia.nl> 1734604578 +0100

parent 64fa395
author Daniel Mursa <daniel@maykinmedia.nl> 1734341658 +0100
committer Daniel Mursa <daniel@maykinmedia.nl> 1734604572 +0100

[#485] Merge closed branch

[#485] Add SitesConfigurationStep and TokenAuthConfigurationStep in settings

[#485] Black and isort

[#485] Fix requirements

[#485] Update namespace

[#486] Update TokenAuthConfigurationStep

[#486] Permissions can be empty list

[#486] Update tests

[#486] New tests

[#486] Update tests

[#486] Fix old tests

[#486] Update data.yaml

[#486] Activate ObjectTypesConfigurationStep

[#486] Add new test

[#486] Update config_cli.rst

[#486] Fix config_cli.rst

[#486] Fix config_cli.rst

[#486] Uniform data.yaml and config_cli.rst

* [#486] Update PrerequisiteFailed in ConfigurationRunFailed

* [#486] Fields type in permissions

* [#486] Update debug message

* [#486] Update permissions fields type

* [#486] Fix tests

* [#486] New test for field_based_authorization

* [#486] Flake8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend support for Tokens via django-setup-configuration with permissions configuration (low prio)
3 participants