-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/486 token permissions configuration #497
Merged
danielmursa-dev
merged 8 commits into
master
from
feature/486-token-permissions-configuration
Dec 19, 2024
Merged
Feature/486 token permissions configuration #497
danielmursa-dev
merged 8 commits into
master
from
feature/486-token-permissions-configuration
Dec 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmursa-dev
requested review from
stevenbal,
swrichards,
Coperh and
SonnyBA
December 18, 2024 09:30
danielmursa-dev
changed the base branch from
master
to
feature/485-token-permissions-setup-configuration
December 18, 2024 10:14
swrichards
requested changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor issues, but otherwise LGTM
src/objects/setup_configuration/tests/test_token_auth_config.py
Outdated
Show resolved
Hide resolved
stevenbal
requested changes
Dec 19, 2024
Base automatically changed from
feature/485-token-permissions-setup-configuration
to
master
December 19, 2024 10:30
author Daniel Mursa <daniel@maykinmedia.nl> 1734341658 +0100 committer Daniel Mursa <daniel@maykinmedia.nl> 1734604578 +0100 parent 64fa395 author Daniel Mursa <daniel@maykinmedia.nl> 1734341658 +0100 committer Daniel Mursa <daniel@maykinmedia.nl> 1734604572 +0100 [#485] Merge closed branch [#485] Add SitesConfigurationStep and TokenAuthConfigurationStep in settings [#485] Black and isort [#485] Fix requirements [#485] Update namespace [#486] Update TokenAuthConfigurationStep [#486] Permissions can be empty list [#486] Update tests [#486] New tests [#486] Update tests [#486] Fix old tests [#486] Update data.yaml [#486] Activate ObjectTypesConfigurationStep [#486] Add new test [#486] Update config_cli.rst [#486] Fix config_cli.rst [#486] Fix config_cli.rst [#486] Uniform data.yaml and config_cli.rst
danielmursa-dev
force-pushed
the
feature/486-token-permissions-configuration
branch
from
December 19, 2024 10:37
5d874de
to
02426aa
Compare
stevenbal
approved these changes
Dec 19, 2024
swrichards
approved these changes
Dec 19, 2024
danielmursa-dev
deleted the
feature/486-token-permissions-configuration
branch
December 19, 2024 13:25
SonnyBA
pushed a commit
that referenced
this pull request
Jan 8, 2025
* parent 64fa395 author Daniel Mursa <daniel@maykinmedia.nl> 1734341658 +0100 committer Daniel Mursa <daniel@maykinmedia.nl> 1734604578 +0100 parent 64fa395 author Daniel Mursa <daniel@maykinmedia.nl> 1734341658 +0100 committer Daniel Mursa <daniel@maykinmedia.nl> 1734604572 +0100 [#485] Merge closed branch [#485] Add SitesConfigurationStep and TokenAuthConfigurationStep in settings [#485] Black and isort [#485] Fix requirements [#485] Update namespace [#486] Update TokenAuthConfigurationStep [#486] Permissions can be empty list [#486] Update tests [#486] New tests [#486] Update tests [#486] Fix old tests [#486] Update data.yaml [#486] Activate ObjectTypesConfigurationStep [#486] Add new test [#486] Update config_cli.rst [#486] Fix config_cli.rst [#486] Fix config_cli.rst [#486] Uniform data.yaml and config_cli.rst * [#486] Update PrerequisiteFailed in ConfigurationRunFailed * [#486] Fields type in permissions * [#486] Update debug message * [#486] Update permissions fields type * [#486] Fix tests * [#486] New test for field_based_authorization * [#486] Flake8
SonnyBA
pushed a commit
that referenced
this pull request
Jan 8, 2025
* parent 64fa395 author Daniel Mursa <daniel@maykinmedia.nl> 1734341658 +0100 committer Daniel Mursa <daniel@maykinmedia.nl> 1734604578 +0100 parent 64fa395 author Daniel Mursa <daniel@maykinmedia.nl> 1734341658 +0100 committer Daniel Mursa <daniel@maykinmedia.nl> 1734604572 +0100 [#485] Merge closed branch [#485] Add SitesConfigurationStep and TokenAuthConfigurationStep in settings [#485] Black and isort [#485] Fix requirements [#485] Update namespace [#486] Update TokenAuthConfigurationStep [#486] Permissions can be empty list [#486] Update tests [#486] New tests [#486] Update tests [#486] Fix old tests [#486] Update data.yaml [#486] Activate ObjectTypesConfigurationStep [#486] Add new test [#486] Update config_cli.rst [#486] Fix config_cli.rst [#486] Fix config_cli.rst [#486] Uniform data.yaml and config_cli.rst * [#486] Update PrerequisiteFailed in ConfigurationRunFailed * [#486] Fields type in permissions * [#486] Update debug message * [#486] Update permissions fields type * [#486] Fix tests * [#486] New test for field_based_authorization * [#486] Flake8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #486