[#21] show version in admin #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annashamray
reviewed
Jun 6, 2024
annashamray
approved these changes
Jun 7, 2024
SonnyBA
force-pushed
the
feature/#21-show-version-admin
branch
from
1c6189e to
db3fd29
Compare
stevenbal
reviewed
Jun 21, 2024
src/objects/conf/base.py
Outdated
Comment on lines
375
to
389
| if "GIT_SHA" in os.environ: | ||
| GIT_SHA = config("GIT_SHA", "") | ||
| # in docker (build) context, there is no .git directory | ||
| elif os.path.exists(os.path.join(BASE_DIR, ".git")): | ||
| try: | ||
| import git | ||
| except ImportError: | ||
| GIT_SHA = None | ||
| else: | ||
| repo = git.Repo(search_parent_directories=True) | ||
| GIT_SHA = repo.head.object.hexsha | ||
| else: | ||
| GIT_SHA = None | ||
|
|
||
| RELEASE = config("RELEASE", GIT_SHA) |
There was a problem hiding this comment.
This will be part of the OAf base settings in the future: #413
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #412 +/- ##
==========================================
+ Coverage 94.84% 95.08% +0.23%
==========================================
Files 135 151 +16
Lines 4657 5225 +568
==========================================
+ Hits 4417 4968 +551
- Misses 240 257 +17 ☔ View full report in Codecov by Sentry. |
SonnyBA
force-pushed
the
feature/#21-show-version-admin
branch
from
6b85aea to
1c14814
Compare
stevenbal
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes maykinmedia/open-api-framework#21
Changes
Shows the current version of the application in the admin: