Define "generic" OpenID Connect init view #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This shim was needed for Django versions <= 3.1
stevenbal
approved these changes
May 16, 2024
There was a problem hiding this comment.
Looks good! Just one very minor question regarding request usage. Also happy to have the tests for the init flow in the library now :)
One thing I was wondering: will this refactor require any changes on the side of the projects that use this library for the simple OIDC admin login flow (i.e. Open Zaak) or will the usage stay the same for those cases?
There should not be any impact! If there is, it's a bug. |
Ported the refactor from Open Forms. The library now ships an OIDCInit view that can handle multiple config classes (and in the future: instances of a single model), which all have tailored behaviours. The default AuthenticationRequestView is now 'just a flavour' of this generic behaviour. We track some additional state and perform additional redirect URL validation for those situations where stricter behaviour of the OIDC flow is desired.
sergei-maertens
force-pushed
the
feature/99-oidc-init-view
branch
from
c77c31f
to
1a033f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #99
This is a port of the
digid_eherkenning_oidc_genericspackage in Open Forms, after its refactor.The approach taken there is more generic than just DigiD/eHerkenning and is useful for our "main" OIDC library.
Authentication backend + callback view will follow in separate PRs.