-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure OIDC login works in combination with SameSite strict settings of open-api-framework #116
Closed
alextreme opened this issue
Sep 17, 2024
· 3 comments
· Fixed by maykinmedia/open-api-framework#72, maykinmedia/objects-api#458, maykinmedia/objecttypes-api#131, open-zaak/open-zaak#1772 or open-zaak/open-notificaties#190
Closed
Ensure OIDC login works in combination with SameSite strict settings of open-api-framework #116
alextreme opened this issue
Sep 17, 2024
· 3 comments
· Fixed by maykinmedia/open-api-framework#72, maykinmedia/objects-api#458, maykinmedia/objecttypes-api#131, open-zaak/open-zaak#1772 or open-zaak/open-notificaties#190
Labels
bug
Something isn't working
Comments
Workaround being tested/applied here: GPP-Woo/GPP-publicatiebank#29 |
@Coperh discussed with Sergei and please set the default to Lax for now, this should be sufficient for the AMS issue (as the complaint was that SameSite wasn't set) |
Coperh
added a commit
to maykinmedia/open-api-framework
that referenced
this issue
Sep 18, 2024
github-project-automation
bot
moved this from Done
to In Progress
in Data en API fundament
Sep 18, 2024
All components that use the latest OAf will not work with OIDC due to this.
Apply workaround that Sergei mentioned. |
This was referenced Sep 27, 2024
github-project-automation
bot
moved this from Implemented
to Done
in Data en API fundament
Sep 27, 2024
github-project-automation
bot
moved this from Done
to In Progress
in Data en API fundament
Sep 27, 2024
github-project-automation
bot
moved this from Implemented
to Done
in Data en API fundament
Oct 1, 2024
github-project-automation
bot
moved this from Done
to In Progress
in Data en API fundament
Oct 1, 2024
6 tasks
github-project-automation
bot
moved this from Implemented
to Done
in Data en API fundament
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
open-api-framework issue, raised by @sergei-maertens
This doesn't work well with Google OIDC (and likely Azure since someone else was running into similar issues). It needs to be set to "Lax". Note that this probably not a problem as soon as you are logged in to google, keycloak can then re-use the existing google session, but for the first login, shit breaks
Suggested workaround: set the session cookie to 'lax' during the oidc login-flow using a custom middleware in mozilla-django-oidc-db, and revert it back to 'strict' afterwards
The text was updated successfully, but these errors were encountered: