-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix uploading header twice if DataFrame is empty, fixes #47 #48
base: master
Are you sure you want to change the base?
Conversation
Sorry for not looking closer into the issue, I think better behaviour would be to upload just columns. empty dataframe is a valid input and I don't think raising an error is correct way to handle it. |
I agree it would be a better way of handling an empty dataframe however it requires quite a few amendments to your code. If you're comfortable with this I will go ahead and work on the code |
Yes, I’m okay with it, ping me if something isn’t clear |
I think I have fixed it, there was an issue with row_names = True if DataFrame was empty too, I should have solved both issues However before pushing the updates want to ask if there was any particular reason you created the clean_worksheet function instead of simply calling wks.clear()? I think it is more efficient compared to calling a different function. |
Hi @22764636, Yes, there was a reason, the idea was to store multiple tables on the same worksheet and being able to clean them up individually, I'd probably want to keep that functionality |
just committed a new update, see if it fits your code |
Thanks, will look into it over the weekend!
…On Wed, 18 Dec 2019 at 16:28, Carmine Migliore ***@***.***> wrote:
just committed a new update, see if it fits your code
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#48?email_source=notifications&email_token=ABHYTNNLUZRCQS3L5BELWFTQZI6THA5CNFSM4JKVXTT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHGPLYI#issuecomment-567080417>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABHYTNMPLKTEFEPGT42O4ULQZI6THANCNFSM4JKVXTTQ>
.
|
returns an error if trying to upload an empty DataFrame to GSheets rather than adding two rows with the DataFrame header