chore: reduce false positive logs

maxwiseman · Mar 13, 2024 · 12052c5 · 12052c5
1 parent dd2181b
commit 12052c5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/apps/frontend/src/app/(dashboard)/classes/[classId]/grades/categories-table.tsx b/apps/frontend/src/app/(dashboard)/classes/[classId]/grades/categories-table.tsx
@@ -16,6 +16,7 @@ import { cn } from "@/lib/utils";
 export function CategoryTable({
   categoryData,
   assignmentData,
+  canLog,
 }: {
   categoryData: AspenCategories;
   assignmentData: {
@@ -28,6 +29,7 @@ export function CategoryTable({
     dateAssigned: Date | string | null;
     dateDue: Date | string | null;
   }[];
+  canLog?: boolean;
 }): React.ReactElement {
   const log = useLogger();
   const calculatedCategories = calculateCategories([...assignmentData], {
@@ -165,7 +167,7 @@ export function CategoryTable({
       // toast.error("Something went wrong while calculating your average!", {
       //   duration: 10000,
       // });
-      log.warn("Something went wrong while calculating averages!");
+      if (canLog) log.warn("Something went wrong while calculating averages!");
     }
 
     return {

diff --git a/apps/frontend/src/app/(dashboard)/classes/[classId]/grades/page.tsx b/apps/frontend/src/app/(dashboard)/classes/[classId]/grades/page.tsx
@@ -51,6 +51,8 @@ export default function Home({
       {categoryData.data || classData.isFetched ? (
         <CategoryTable
           assignmentData={assignmentAspenData.data || assignmentData.data || []}
+          // eslint-disable-next-line react/jsx-no-leaked-render -- This is a prop
+          canLog={assignmentAspenData.isFetched && categoryData.isFetched}
           categoryData={
             categoryData.isFetched && categoryData.data
               ? categoryData.data