Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor TQC #1

Merged
merged 6 commits into from
Nov 10, 2023
Merged

Refactor TQC #1

merged 6 commits into from
Nov 10, 2023

Conversation

vmoens
Copy link

@vmoens vmoens commented Nov 7, 2023

I added TQC to the losses and the doc.

There's a bunch of stuff still to be done:

  • test the various configs of the model (eg, passing the target entropy vs not, passing the action spec vs not etc)
  • fix the failing tests
  • Adding docstrings to the loss class

LMK if it makes sense

@vmoens vmoens changed the title Refactor tcq Refactor TQC Nov 7, 2023
@vmoens vmoens mentioned this pull request Nov 9, 2023
Open
6 tasks
maxweissenbacher
maxweissenbacher approved these changes Nov 10, 2023
View reviewed changes
Copy link
Owner

@maxweissenbacher maxweissenbacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@maxweissenbacher maxweissenbacher merged commit 2e56b5b into maxweissenbacher:main Nov 10, 2023
@vmoens vmoens deleted the refactor_tcq branch November 27, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxweissenbacher maxweissenbacher maxweissenbacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vmoens @maxweissenbacher @albertbou92