Prevent exception due to value not being set #261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case described, the value is set to None, so it is in the dict. This raised the exception mentionned.
1 similar comment
|
Hi @sposs It took me a while to reply... Sorry about that and thanks for raising this issue, the problem was actually way more serious as we were raising the exception for all attributes that actually exist, but their value was set to None, so this PR wasn't enough and we had to make a global fix (0de5689) which will work for all resources. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case described, the value is set to None, so it is in the dict. This raises the exception mentioned. The fix prevents the error.