Fix file generation error on multiple CMake configurations reload #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Random errors look like this |
fameowner99
force-pushed
the
fix_multiple_configuration_file_write_error
branch
from
8cc5fbc to
0f7203a
Compare
|
It appears the |
Propose to move generated file to binary directory because it creates from different CMake configuration at the same time and it is race condition
fameowner99
force-pushed
the
fix_multiple_configuration_file_write_error
branch
from
0f7203a to
25a3b3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propose to move generated file to binary directory because it creates from different CMake configuration at the same time and it is race condition
The problems occures when you have multiple CMake configurations for example Release, Relwithdebinfo, Debug.
And when you reload CMake at same time every configuration try to modify file in same location maxminddb_config.h.
So easiest fix is to move generated file per configuration.