Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace table of GeoIP client APIs with links to specific sections of… #1243

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kevcenteno
Copy link
Member

… the db documentation landing page

Copy link

cloudflare-workers-and-pages bot commented Dec 10, 2024

Deploying dev-site with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9dd2de3
Status: ✅  Deploy successful!
Preview URL: https://36d53bdc.dev-site-4ua.pages.dev
Branch Preview URL: https://kevin-client-apis.dev-site-4ua.pages.dev

View logs

@kevcenteno kevcenteno force-pushed the kevin/client-apis branch 2 times, most recently from 1315ae4 to d71aa8e Compare December 10, 2024 18:39
@@ -1,7 +1,10 @@
Binary databases make use of the
[MaxMind DB file format](https://maxmind.github.io/MaxMind-DB/). MaxMind
provides official client APIs in the language listed below. The following client
APIs are open source and licensed under the Apache License, Version 2.0.
provides [official client APIs](https://dev.maxmind.com/geoip/docs/databases/#official-client-apis)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These links probably shouldn't include the scheme and hostname. It might make sense to use ref/relref too, but I don't see us using that Hugo feature elsewhere.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch: 9dd2de3

Copy link
Member

@oschwald oschwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I don't know if anyone else needs to sign-off on this so I'll hold off merging.

provides official client APIs in the language listed below. The following client
APIs are open source and licensed under the Apache License, Version 2.0.
provides [official client APIs](/geoip/docs/databases/#official-client-apis)
that are open source and licensed under the Apache License, Version 2.0. We also provide a list of
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not new, but for newer things, we tend to license under Apache 2 or MIT rather than just Apache 2. This makes our libraries more compatible with GPL v2. The Ruby libraries, for instance, are licensed this way.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay, should I mention that our open source libraries are licensed under either Apache or MIT, or could I just omit mentioning the license types?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally think we could just leave it vague without specifying the particular licenses. @christophermluna do you have a preference?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants