Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runtime define prevents opcache preloading #134

Closed
vedadkajtaz opened this issue Oct 14, 2021 · 1 comment · Fixed by #135
Closed

Runtime define prevents opcache preloading #134

vedadkajtaz opened this issue Oct 14, 2021 · 1 comment · Fixed by #135

Comments

@vedadkajtaz
Copy link

Hello,

The following runtime define:

MaxMind-DB-Reader-php/src/MaxMind/Db/Reader/Decoder.php

Line 15 in 83f0765

\define(__NAMESPACE__ . '\_MM_MAX_INT_BYTES', (int) ((log(\PHP_INT_MAX, 2) - 1) / 8));

gets lost when using opcache preloading, resulting in the following warning:

PHP Warning: Use of undefined constant _MM_MAX_INT_BYTES - assumed '_MM_MAX_INT_BYTES' (this will throw an Error in a future version of PHP) in ...
oschwald added a commit that referenced this issue Oct 15, 2021
@oschwald
Remove runtime define of constant
8b2a9f3 
I am not sure why we didn't use PHP_INT_SIZE in the first place.
Using log is too clever and doesn't accomplish much.

Closes #134.
@oschwald oschwald mentioned this issue Oct 15, 2021
Merged
@oschwald
Copy link
Member

Thanks for the report. This is fixed in 1.11.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove runtime define of constant maxmind/MaxMind-DB-Reader-php
2 participants
@oschwald @vedadkajtaz