Improve TimeOnly's example value

[tinohager]

Hello thank you for the package. I noticed another small thing with the TimeOnly example - it doesn't contain milliseconds

While server response does:

My suggestion would be as follows, the example time is from this documentation
https://docs.microsoft.com/en-us/dotnet/standard/base-types/standard-date-and-time-format-strings#Roundtrip

[maxkoshevoi]

Hi, thanks for the contribution! Could you please clarify the issue? Are you saying that example value doesn't have .0000000 at the end, and thus doesn't fully represent the TimeOnly type?

[tinohager]

Hi, thanks for the contribution! Could you please clarify the issue? Are you saying that example value doesn't have .0000000 at the end, and thus doesn't fully represent the TimeOnly type?

I have not found any information on how exactly the time format is defined. I have only adapted it to the return value.

[maxkoshevoi]

I have not found any information on how exactly the time format is defined. I have only adapted it to the return value.

Got it. What about https://docs.microsoft.com/en-us/dotnet/api/system.timeonly ?

Represents a time of day, as would be read from a clock, within the range 00:00:00 to 23:59:59.9999999

[tinohager]

That would fit for example or?

[maxkoshevoi]

• Do you know how American time format is handled (AM/PM)? Or does TimeOnly support only 24-hour-format? Does serviver return different results for different locales?
• Could you replace 30 minutes with 42? I like the 42 reference 😅

[tinohager]

TimeOnly isn’t associated with any particular date, it is best visualized as a circular analog clock that might hang on your wall (albeit a 24-hour clock, not a 12-hour clock). https://devblogs.microsoft.com/dotnet/date-time-and-time-zone-enhancements-in-net-6/

[maxkoshevoi]

What is a sample value for TimeSpan? Seems like it should be similar to TimeOnly

[tinohager]

dotnet/runtime#53539

TimeOnly	"HH':'mm':'ss[FFFFFFF]"	ISO 8601: Time without UTC offset information

[maxkoshevoi]

I have no doubts regarding TimeOnly, and agree that sample should represent full format. But in the article you mentioned above there's a good point that TimeOnly is pretty similar to TimeSpan. So I was wondering, how does it's (TimeSpan's) sample value looks like.
I'm quite busy right now, so cannot check myself.

[maxkoshevoi]

Looks like TimeSpan doesn't have a sample value. LGTM then, thanks for the contribution!