Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ImgBot] Optimize images #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[ImgBot] Optimize images #1

wants to merge 1 commit into from

Conversation

imgbot[bot]
Copy link

@imgbot imgbot bot commented Jun 30, 2020

Beep boop. Optimizing your images is my life. https://imgbot.net/ for more information.

@imgbot imgbot bot force-pushed the imgbot branch 5 times, most recently from b8ed836 to d36404d Compare October 10, 2020 15:48
background-color: rgba(0,0,0,.12);
}

.switch label input[type=checkbox][disabled] + .lever:after,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid qualifying attribute selectors with an element.
Begin pseudo elements with double colons: ::
Selector should have depth of applicability no greater than 2, but was 3

// Disabled Styles
.switch input[type=checkbox][disabled] + .lever {
cursor: default;
background-color: rgba(0,0,0,.12);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Color literals like rgba(0, 0, 0, 0.12) should only be used in variable declarations; they should be referred to via variable everywhere else.
Commas in function arguments should be followed by one space
.12 should be written with a leading zero as 0.12


// Disabled Styles
.switch input[type=checkbox][disabled] + .lever {
cursor: default;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Properties should be ordered background-color, cursor

}

// Disabled Styles
.switch input[type=checkbox][disabled] + .lever {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid qualifying attribute selectors with an element.

input[type=checkbox]:not(:disabled) ~ .lever:active:before,
input[type=checkbox]:not(:disabled).tabbed:focus ~ .lever::before {
transform: scale(2.4);
background-color: rgba(0,0,0,.08);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Color literals like rgba(0, 0, 0, 0.08) should only be used in variable declarations; they should be referred to via variable everywhere else.
Commas in function arguments should be followed by one space
.08 should be written with a leading zero as 0.08

background-color: transparentize($switch-bg-color, .85);
}

&:after {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Begin pseudo elements with double colons: ::
Selector should have depth of applicability no greater than 2, but was 3

}

&:before {
background-color: transparentize($switch-bg-color, .85);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.85 should be written with a leading zero as 0.85

transition: left 0.3s ease, background .3s ease, box-shadow 0.1s ease, transform .1s ease;
}

&:before {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Begin pseudo elements with double colons: ::
Selector should have depth of applicability no greater than 2, but was 3

border-radius: 50%;
left: 0;
top: -3px;
transition: left 0.3s ease, background .3s ease, box-shadow 0.1s ease, transform .1s ease;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.1 should be written with a leading zero as 0.1
.3 should be written with a leading zero as 0.3

margin: 0 16px;

&:before, &:after {
content: "";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Properties should be ordered border-radius, content, display, height, left, position, top, transition, width

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant