Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added option cleanUpAfterCopy #197

Merged
merged 4 commits into from
Jul 3, 2019
Merged

Conversation

DmitryEfimenko
Copy link

closes #196

In addition to adding new feature I also added:

  • a workspace level IDE setting to use 4 tabspaces. (My personal configuration is 2 spaces and it was messing up spacing of all files)
  • test:watch script for convinience

@maxisam
Copy link
Owner

maxisam commented Jun 27, 2019

I still think we should leave setting.json out of repo. However, I agree that we should have something to handle style. I will handle it in a different pull request #198. The rest of code looks good to me. It will be nice if you can write a test case for this as well.

@DmitryEfimenko
Copy link
Author

removed settings.json. Please let me know if everything look good to you or not

@maxisam
Copy link
Owner

maxisam commented Jul 3, 2019

Thank you!

@maxisam maxisam merged commit 44ffb40 into maxisam:master Jul 3, 2019
@maxisam
Copy link
Owner

maxisam commented Jul 3, 2019

please try it at 12.2.0-beta.01

@DmitryEfimenko
Copy link
Author

works like a charm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clean up the temp textarea
2 participants