Skip to content

Commit

Permalink
bump gRPC and protobuf versions, use the new edition notation instead…
Browse files Browse the repository at this point in the history
… of the syntax notation and switch out the license header action
  • Loading branch information
maximilianpilz committed Feb 21, 2024
1 parent 16243b7 commit 21ac100
Show file tree
Hide file tree
Showing 35 changed files with 119 additions and 101 deletions.
12 changes: 6 additions & 6 deletions .github/license-check/header-MIT-draeger-java.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*
This Source Code Form is subject to the terms of the MIT License.
Copyright (c) %year% Draegerwerk AG & Co. KGaA.

SPDX-License-Identifier: MIT
*/
/\*
\* This Source Code Form is subject to the terms of the MIT License.
\* Copyright \(c\) (?:([0-9]{4}-[0-9]{4})|([0-9]{4}))(?:, (?:([0-9]{4}-[0-9]{4})|([0-9]{4})))* Draegerwerk AG & Co. KGaA.
\*
\* SPDX-License-Identifier: MIT
\*/
12 changes: 6 additions & 6 deletions .github/license-check/header-MIT-draeger-proto.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*
This Source Code Form is subject to the terms of the MIT License.
Copyright (c) %year% Draegerwerk AG & Co. KGaA.

SPDX-License-Identifier: MIT
*/
/\*
\* This Source Code Form is subject to the terms of the MIT License.
\* Copyright \(c\) (?:([0-9]{4}-[0-9]{4})|([0-9]{4}))(?:, (?:([0-9]{4}-[0-9]{4})|([0-9]{4})))* Draegerwerk AG & Co. KGaA.
\*
\* SPDX-License-Identifier: MIT
\*/
2 changes: 1 addition & 1 deletion .github/license-check/header-MIT-draeger-python.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# This Source Code Form is subject to the terms of the MIT License.
#
# Copyright (c) %year% Draegerwerk AG & Co. KGaA.
# Copyright (c) (?:([0-9]{4}-[0-9]{4})|([0-9]{4}))(?:, (?:([0-9]{4}-[0-9]{4})|([0-9]{4})))* Draegerwerk AG & Co. KGaA.
# SPDX-License-Identifier: MIT
23 changes: 23 additions & 0 deletions .github/license-check/license-config
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
[DraegerLicenseMITforJava]
file_name_pattern: tests/java/src/**/*.java
file_header_encoding: utf-8
header_regex_file: .github/license-check/header-MIT-draeger-java.txt
header_regex_file_encoding: utf-8

[DraegerLicenseMITforProto]
file_name_pattern: src/**/*.proto
file_header_encoding: utf-8
header_regex_file: .github/license-check/header-MIT-draeger-proto.txt
header_regex_file_encoding: utf-8

[DraegerLicenseMITforPythonSource]
file_name_pattern: python/**/*.py
file_header_encoding: utf-8
header_regex_file: .github/license-check/header-MIT-draeger-python.txt
header_regex_file_encoding: utf-8

[DraegerLicenseMITforPythonTests]
file_name_pattern: tests/python/**/*.py
file_header_encoding: utf-8
header_regex_file: .github/license-check/header-MIT-draeger-python.txt
header_regex_file_encoding: utf-8
25 changes: 0 additions & 25 deletions .github/license-check/license-config.json

This file was deleted.

10 changes: 5 additions & 5 deletions .github/workflows/license-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ jobs:
runs-on: ubuntu-latest
steps:
# Run `git checkout`
- uses: actions/checkout@v3
- uses: viperproject/check-license-header@v1
- uses: actions/checkout@v4
- uses: maximilianpilz/file-header-check@v1
with:
path: .
config: .github/license-check/license-config.json
strict: false # <boolean indicating whether files not covered by the configuration should be reported as errors>
config: '.github/license-check/license-config'
config-encoding: 'utf-8'
log-level: 'DEBUG'
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- gRPC version to 1.60.1
- protoc version to 25.0
- protobuf syntax notation to edition notation

## [4.0.0] - 2023-11-20

### Added
Expand Down
2 changes: 1 addition & 1 deletion LICENSE
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
MIT License

Copyright (c) 2022 Draegerwerk AG & Co. KGaA
Copyright (c) 2022-2024 Draegerwerk AG & Co. KGaA

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
Expand Down
12 changes: 6 additions & 6 deletions config/versions.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
BASE_PACKAGE_VERSION=4.1.0
COMMON_PROTOC_VERSION=24.1
JAVA_PROTOC_VERSION=3.24.1
JAVA_GRPC_VERSION=1.58.0
PYTHON_PROTOC_VERSION=4.24.1
PYTHON_GRPC_VERSION=1.58.0
BASE_PACKAGE_VERSION=5.0.0
COMMON_PROTOC_VERSION=25.0
JAVA_PROTOC_VERSION=3.25.0
JAVA_GRPC_VERSION=1.60.1
PYTHON_PROTOC_VERSION=4.25.0
PYTHON_GRPC_VERSION=1.60.1
5 changes: 3 additions & 2 deletions src/t2iapi/activation_state/activation_state_requests.proto
Original file line number Diff line number Diff line change
@@ -1,16 +1,17 @@
/*
This Source Code Form is subject to the terms of the MIT License.
Copyright (c) 2022 Draegerwerk AG & Co. KGaA.
Copyright (c) 2022-2024 Draegerwerk AG & Co. KGaA.
SPDX-License-Identifier: MIT
*/

syntax = "proto3";
edition = "2023";

Check failure on line 8 in src/t2iapi/activation_state/activation_state_requests.proto

View workflow job for this annotation

GitHub Actions / lint-protos

editions are not yet supported; use syntax proto2 or proto3 instead

package t2iapi.activation_state;

import "t2iapi/activation_state/types.proto";

option features.field_presence = IMPLICIT;
option java_package = "com.draeger.medical.t2iapi.activation_state";
option java_outer_classname = "ActivationStateRequests";

Expand Down
4 changes: 2 additions & 2 deletions src/t2iapi/activation_state/service.proto
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
/*
This Source Code Form is subject to the terms of the MIT License.
Copyright (c) 2022 Draegerwerk AG & Co. KGaA.
Copyright (c) 2022-2024 Draegerwerk AG & Co. KGaA.
SPDX-License-Identifier: MIT
*/

syntax = "proto3";
edition = "2023";

Check failure on line 8 in src/t2iapi/activation_state/service.proto

View workflow job for this annotation

GitHub Actions / lint-protos

editions are not yet supported; use syntax proto2 or proto3 instead

package t2iapi.activation_state;

Expand Down
4 changes: 2 additions & 2 deletions src/t2iapi/activation_state/types.proto
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
/*
This Source Code Form is subject to the terms of the MIT License.
Copyright (c) 2022 Draegerwerk AG & Co. KGaA.
Copyright (c) 2022-2024 Draegerwerk AG & Co. KGaA.
SPDX-License-Identifier: MIT
*/

syntax = "proto3";
edition = "2023";

Check failure on line 8 in src/t2iapi/activation_state/types.proto

View workflow job for this annotation

GitHub Actions / lint-protos

editions are not yet supported; use syntax proto2 or proto3 instead

package t2iapi.activation_state;

Expand Down
5 changes: 3 additions & 2 deletions src/t2iapi/alert/alert_requests.proto
Original file line number Diff line number Diff line change
@@ -1,16 +1,17 @@
/*
This Source Code Form is subject to the terms of the MIT License.
Copyright (c) 2022 Draegerwerk AG & Co. KGaA.
Copyright (c) 2022-2024 Draegerwerk AG & Co. KGaA.
SPDX-License-Identifier: MIT
*/

syntax = "proto3";
edition = "2023";

Check failure on line 8 in src/t2iapi/alert/alert_requests.proto

View workflow job for this annotation

GitHub Actions / lint-protos

editions are not yet supported; use syntax proto2 or proto3 instead

package t2iapi.alert;

import "t2iapi/alert/types.proto";

option features.field_presence = IMPLICIT;
option java_package = "com.draeger.medical.t2iapi.alert";
option java_outer_classname = "AlertRequests";

Expand Down
4 changes: 2 additions & 2 deletions src/t2iapi/alert/service.proto
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
/*
This Source Code Form is subject to the terms of the MIT License.
Copyright (c) 2022 Draegerwerk AG & Co. KGaA.
Copyright (c) 2022-2024 Draegerwerk AG & Co. KGaA.
SPDX-License-Identifier: MIT
*/

syntax = "proto3";
edition = "2023";

Check failure on line 8 in src/t2iapi/alert/service.proto

View workflow job for this annotation

GitHub Actions / lint-protos

editions are not yet supported; use syntax proto2 or proto3 instead

package t2iapi.alert;

Expand Down
4 changes: 2 additions & 2 deletions src/t2iapi/alert/types.proto
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
/*
This Source Code Form is subject to the terms of the MIT License.
Copyright (c) 2022 Draegerwerk AG & Co. KGaA.
Copyright (c) 2022-2024 Draegerwerk AG & Co. KGaA.
SPDX-License-Identifier: MIT
*/

syntax = "proto3";
edition = "2023";

Check failure on line 8 in src/t2iapi/alert/types.proto

View workflow job for this annotation

GitHub Actions / lint-protos

editions are not yet supported; use syntax proto2 or proto3 instead

package t2iapi.alert;

Expand Down
5 changes: 3 additions & 2 deletions src/t2iapi/basic_requests.proto
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
/*
This Source Code Form is subject to the terms of the MIT License.
Copyright (c) 2022 Draegerwerk AG & Co. KGaA.
Copyright (c) 2022-2024 Draegerwerk AG & Co. KGaA.
SPDX-License-Identifier: MIT
*/

syntax = "proto3";
edition = "2023";

Check failure on line 8 in src/t2iapi/basic_requests.proto

View workflow job for this annotation

GitHub Actions / lint-protos

editions are not yet supported; use syntax proto2 or proto3 instead

package t2iapi;

option features.field_presence = IMPLICIT;
option java_package = "com.draeger.medical.t2iapi";
option java_outer_classname = "BasicRequests";

Expand Down
5 changes: 3 additions & 2 deletions src/t2iapi/basic_responses.proto
Original file line number Diff line number Diff line change
@@ -1,16 +1,17 @@
/*
This Source Code Form is subject to the terms of the MIT License.
Copyright (c) 2022 Draegerwerk AG & Co. KGaA.
Copyright (c) 2022-2024 Draegerwerk AG & Co. KGaA.
SPDX-License-Identifier: MIT
*/

syntax = "proto3";
edition = "2023";

Check failure on line 8 in src/t2iapi/basic_responses.proto

View workflow job for this annotation

GitHub Actions / lint-protos

editions are not yet supported; use syntax proto2 or proto3 instead

package t2iapi;

import "t2iapi/response_types.proto";

option features.field_presence = IMPLICIT;
option java_package = "com.draeger.medical.t2iapi";
option java_outer_classname = "BasicResponses";

Expand Down
4 changes: 2 additions & 2 deletions src/t2iapi/combined/combined_requests.proto
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Copyright (c) 2023 Draegerwerk AG & Co. KGaA.
SPDX-License-Identifier: MIT
*/

syntax = "proto3";
edition = "2023";

Check failure on line 8 in src/t2iapi/combined/combined_requests.proto

View workflow job for this annotation

GitHub Actions / lint-protos

editions are not yet supported; use syntax proto2 or proto3 instead

package t2iapi.combined;

Expand All @@ -14,7 +14,7 @@ import "t2iapi/operation/types.proto";
import "t2iapi/activation_state/types.proto";
import "t2iapi/metric/types.proto";


option features.field_presence = IMPLICIT;
option java_package = "com.draeger.medical.t2iapi.combined";
option java_outer_classname = "CombinedRequests";

Expand Down
2 changes: 1 addition & 1 deletion src/t2iapi/combined/service.proto
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Copyright (c) 2023 Draegerwerk AG & Co. KGaA.
SPDX-License-Identifier: MIT
*/

syntax = "proto3";
edition = "2023";

Check failure on line 8 in src/t2iapi/combined/service.proto

View workflow job for this annotation

GitHub Actions / lint-protos

editions are not yet supported; use syntax proto2 or proto3 instead

package t2iapi.combined;

Expand Down
5 changes: 3 additions & 2 deletions src/t2iapi/context/context_requests.proto
Original file line number Diff line number Diff line change
@@ -1,16 +1,17 @@
/*
This Source Code Form is subject to the terms of the MIT License.
Copyright (c) 2022 Draegerwerk AG & Co. KGaA.
Copyright (c) 2022-2024 Draegerwerk AG & Co. KGaA.
SPDX-License-Identifier: MIT
*/

syntax = "proto3";
edition = "2023";

package t2iapi.context;

import "t2iapi/context/types.proto";

option features.field_presence = IMPLICIT;
option java_package = "com.draeger.medical.t2iapi.context";
option java_outer_classname = "ContextRequests";

Expand Down
5 changes: 3 additions & 2 deletions src/t2iapi/context/context_responses.proto
Original file line number Diff line number Diff line change
@@ -1,18 +1,19 @@
/*
This Source Code Form is subject to the terms of the MIT License.
Copyright (c) 2022 Draegerwerk AG & Co. KGaA.
Copyright (c) 2022-2024 Draegerwerk AG & Co. KGaA.
SPDX-License-Identifier: MIT
*/

syntax = "proto3";
edition = "2023";

package t2iapi.context;

import "t2iapi/basic_responses.proto";
import "t2iapi/response_types.proto";
import "t2iapi/context/types.proto";

option features.field_presence = IMPLICIT;
option java_package = "com.draeger.medical.t2iapi.context";
option java_outer_classname = "ContextResponses";

Expand Down
4 changes: 2 additions & 2 deletions src/t2iapi/context/service.proto
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
/*
This Source Code Form is subject to the terms of the MIT License.
Copyright (c) 2022 Draegerwerk AG & Co. KGaA.
Copyright (c) 2022-2024 Draegerwerk AG & Co. KGaA.
SPDX-License-Identifier: MIT
*/

syntax = "proto3";
edition = "2023";

package t2iapi.context;

Expand Down
5 changes: 3 additions & 2 deletions src/t2iapi/context/types.proto
Original file line number Diff line number Diff line change
@@ -1,16 +1,17 @@
/*
This Source Code Form is subject to the terms of the MIT License.
Copyright (c) 2022 Draegerwerk AG & Co. KGaA.
Copyright (c) 2022-2024 Draegerwerk AG & Co. KGaA.
SPDX-License-Identifier: MIT
*/

syntax = "proto3";
edition = "2023";

package t2iapi.context;

import "google/protobuf/wrappers.proto";

option features.field_presence = IMPLICIT;
option java_package = "com.draeger.medical.t2iapi.context";
option java_outer_classname = "ContextTypes";

Expand Down
5 changes: 3 additions & 2 deletions src/t2iapi/device/device_requests.proto
Original file line number Diff line number Diff line change
@@ -1,16 +1,17 @@
/*
This Source Code Form is subject to the terms of the MIT License.
Copyright (c) 2022 Draegerwerk AG & Co. KGaA.
Copyright (c) 2022-2024 Draegerwerk AG & Co. KGaA.
SPDX-License-Identifier: MIT
*/

syntax = "proto3";
edition = "2023";

package t2iapi.device;

import "t2iapi/device/types.proto";

option features.field_presence = IMPLICIT;
option java_package = "com.draeger.medical.t2iapi.device";
option java_outer_classname = "DeviceRequests";

Expand Down
Loading

0 comments on commit 21ac100

Please sign in to comment.