-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use paraglidable forecast #3
Conversation
afd3630
to
5eb8ef1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
coucou
paralert/paraglidable.py
Outdated
response = requests.get("https://api.paraglidable.com/?key=d60092fb1105a1f4&format=JSON&version=1") | ||
forecast_pgble = json.loads(response.text) | ||
|
||
utilities.write_to_JSON_file('./paraglidable_forecast/', 'forecast_pgble', forecast_pgble) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ce serait bien de pas avoir à enregistrer dans un fichier (Ca impose d'avoir des paths en dur dans le code + de créer un dossier + gérer les vieux fichiers) . On peut passer le json en sortie de la fonction non ? @maximepiton
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
paralert/utilities.py
Outdated
@@ -0,0 +1,16 @@ | |||
import json | |||
from datetime import datetime, timedelta | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aaah mais je croyais que tu utilisais ça : https://docs.python.org/3.7/c-api/utilities.html
Peut être changer le nom du fichier pour pas que ça soit celui d'une lib par défaut.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in paralert_tool
|
||
for x in range (0, len(pgble)): | ||
print( | ||
"Site : " + pgble[x][0] + '\n' + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha, nous fait pas une clément à aligner les symboles. @maximepiton va te faire passer son linter sur tout ça !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vas'y max, je t'en pris :)
Yee :)
Le dim. 24 mars 2019 à 19:15, maximepiton <notifications@github.com> a
écrit :
… Merged #3 <#3> into master.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#3 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/At-kownCpFvR1XZ5_Rnp_KhC7SMwWRd8ks5vZ8CygaJpZM4bmxV2>
.
|
No description provided.