test: autodiscover roles in local and ci tests (#46)

.github/workflows/ci-roles.yml

@@ -15,16 +15,34 @@ defaults:
     working-directory: "smallstep"
 
 jobs:
+  discover-roles:
+    runs-on: ubuntu-latest
+    outputs:
+      roles: ${{ steps.set-roles.outputs.roles }}
+    steps:
+      - name: Check out codebase
+        uses: actions/checkout@v2
+        with:
+          path: "smallstep"
+      - name: Set up Python 3
+        uses: actions/setup-python@v2
+        with:
+          python-version: "3.6"
+      - name: Discover roles
+        id: set-roles
+        run: |
+          export roles=$(python3 -c "import os; import json; print(json.dumps(os.listdir('roles')));")
+          echo "::set-output name=roles::$roles"
+
   molecule:
     name: "${{ matrix.role }} ${{ matrix.ansible-version }}"
+    needs: discover-roles
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false
       max-parallel: 10
       matrix:
-        role:
-          - step_ca
-          - step_cli
+        role: ${{ fromJson(needs.discover-roles.outputs.roles) }}
         ansible-version:
           - stable-2.9
           - stable-2.10
@@ -49,6 +67,7 @@ jobs:
 
       - name: Run ansible-lint
         run: ansible-lint -vv
+
       - name: Run Molecule tests
         run: molecule test
         working-directory: "smallstep/roles/${{ matrix.role }}"

CONTRIBUTING.md

@@ -68,7 +68,7 @@ Example: `fix(step_ca): clean up files on EL8`
 
 #### Hints for role development
 
-- If you are adding a new role, make sure to add its molecule tests to both the hacking script and the CI job
+None so far
 
 ### Update Tests and Documentation
 

hacking/test_modules.sh

@@ -1,5 +1,13 @@
 #!/usr/bin/env bash
 
+set -eu
+
+cleanup() {
+    ./hacking/cleanup.sh
+}
+
+trap cleanup err exit
+
 ./hacking/build.sh
 
 ansible-galaxy collection install maxhoesel-smallstep-*.tar.gz -p .
@@ -8,5 +16,3 @@ ansible-galaxy collection install maxhoesel-smallstep-*.tar.gz -p .
     && ansible-test sanity --docker --requirements -v --color --python 3.6 plugins/ \
     && ansible-test integration --docker --requirements -v --coverage --color --python 3.6 \
 )
-
-./hacking/cleanup.sh

hacking/test_roles.sh

@@ -1,8 +1,15 @@
 #!/usr/bin/env bash
 
-(ansible-lint -v \
-    && (cd roles/step_cli && molecule test) \
-    && (cd roles/step_ca && molecule test) \
-)
+set -eu
 
-./hacking/cleanup.sh
+cleanup() {
+    ./hacking/cleanup.sh
+}
+
+trap cleanup err exit
+
+ansible-lint -v
+
+for role in roles/*; do
+    (cd "$role" && molecule test)
+done