raw parent is properly set when updated (#985)

maxence-charriere · Aug 22, 2024 · 4c248da · 4c248da
1 parent 16d1aea
commit 4c248da
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/pkg/app/node.go b/pkg/app/node.go
@@ -605,6 +605,7 @@ func (m nodeManager) updateRawHTML(ctx Context, v, new *raw) (UI, error) {
 	for parent := v.parent(); parent != nil; parent = parent.parent() {
 		if parent, isHTML := parent.(HTML); isHTML {
 			parent.JSValue().replaceChild(newMount, v)
+			newMount.setParent(parent)
 			break
 		}
 	}

diff --git a/pkg/app/node_test.go b/pkg/app/node_test.go
@@ -841,6 +841,7 @@ func TestNodeManagerUpdate(t *testing.T) {
 		require.IsType(t, Raw(""), newSpan)
 		require.Equal(t, "<span>bye</span>", newSpan.(*raw).value)
 		require.True(t, newSpan.Mounted())
+		require.Equal(t, body, newSpan.parent())
 		require.False(t, span.Mounted())
 	})