Add a customizable diesel backed session store #42
Conversation
|
This is fantastic. Thank you! |
|
Should we add an integration test while we're at it? I've done that for the SQLx stores we support. |
|
Can you point to where to add these tests? |
|
We should be able to put them somewhere in here: https://github.com/maxcountryman/tower-sessions/blob/main/tests/integration-tests.rs |
weiznich
force-pushed
the
diesel_support
branch
from
25303ba
to
fc77e18
Compare
|
It looks like some of the integration tests are failing. |
|
I've tried to reproduce the error locally but they are passing for me. It seems like that this issue is caused by a racing condition while applying the |
|
That sounds like it could be the culprit. I had to work around this with some of the SQLx stores. I'm not sure what the correct thing to do here is, since it seems unlikely to matter in a real application. |
This commit adds a custom diesel backed session store. It abstracts over different database backends and allows to customize the used session table.
This also enables the "bundled" feature for libsqlite to not care about getting libsqlite3 setup everywhere
weiznich
force-pushed
the
diesel_support
branch
from
fc77e18
to
57e9cc8
Compare
Diesel uses libmysqlclient internally, which tries to be clever by using a unix socket instead of a network socket if it sees a database url that contains `localhost` as a host name. That won't work in this case, as the db is running in a docker container. This change switches to use `127.0.0.1` as host instead which forces the usage of a network socket.
Codecov Report
@@ Coverage Diff @@
## main #42 +/- ##
==========================================
- Coverage 84.51% 82.72% -1.79%
==========================================
Files 13 14 +1
Lines 465 579 +114
==========================================
+ Hits 393 479 +86
- Misses 72 100 +28
|
This commit adds a custom diesel backed session store. It abstracts over different database backends and allows to customize the used session table.
This partially addresses #26 (the diesel part, not the diesel-async part)