BoardInfo: Add FMUv5X #9764
Merged
BoardInfo: Add FMUv5X #9764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrpollo
commented
Jul 13, 2021
| @@ -54,6 +55,8 @@ | |||
| { "regExp": "^PX4 BL FMU v6U.x$", "boardClass": "Pixhawk" }, | |||
| { "regExp": "^PX4 FMU v6X.x$", "boardClass": "Pixhawk" }, | |||
| { "regExp": "^PX4 BL FMU v6X.x$", "boardClass": "Pixhawk" }, | |||
| { "regExp": "^PX4 FMU v5X.x$", "boardClass": "Pixhawk" }, | |||
| { "regExp": "^PX4 BL FMU v5X.x$", "boardClass": "Pixhawk" }, | |||
| { "regExp": "^PX4 FMU v5.x$", "boardClass": "Pixhawk" }, | |||
There was a problem hiding this comment.
@dagar not sure how is the regex working on the other end, but would the dot "." on this line need to be escaped to avoid the regex from catching an X or any other char other than the dot?
|
Vendor: Pixhawk? |
LorenzMeier
approved these changes
Jul 13, 2021
|
@LorenzMeier USB Vendor ID is set to 0x3185 |
davids5
reviewed
Aug 9, 2021
| @@ -13,6 +13,7 @@ | |||
| { "vendorID": 9900, "productID": 33, "boardClass": "Pixhawk", "name": "AUAV X2.1 FMU V2" }, | |||
| { "vendorID": 9900, "productID": 48, "boardClass": "Pixhawk", "name": "MindPX FMU V2" }, | |||
| { "vendorID": 9900, "productID": 50, "boardClass": "Pixhawk", "name": "PX4 FMU V5" }, | |||
| { "vendorID": 9900, "productID": 51, "boardClass": "Pixhawk", "name": "PX4 FMU V5X" }, | |||
There was a problem hiding this comment.
@mrpollo @LorenzMeier The bootloader that has been out for years use 12677
There was a problem hiding this comment.
Thanks, I sent the following #9816
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@LorenzMeier @dagar, what would be the proper
vendorIDfor FMUv5X?