Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle joysticks with duplicate names #5501

Merged

Conversation

jaxxzer
Copy link
Collaborator

@jaxxzer jaxxzer commented Jul 26, 2017

Also handle a segfault issue that has been plaguing me for a while by commenting out call to SDL_JoystickClose

@jaxxzer jaxxzer closed this Jul 26, 2017
@jaxxzer jaxxzer reopened this Jul 26, 2017
@jaxxzer jaxxzer closed this Jul 26, 2017
@jaxxzer jaxxzer reopened this Jul 26, 2017
@hamishwillee
Copy link
Contributor

@jaxxzer Does this have a docs impact?
Specifically, it sounds like you can have multiple joysticks connected, and that this change allows that to work. However we don't have any information about multiple joysicks here.

Can you help me understand this?

@jaxxzer
Copy link
Collaborator Author

jaxxzer commented Jul 28, 2017

We have allowed multiple joysticks to be connected for quite some time. We are always using only one joystick at any time. The joystick we are using is selected from the dropdown on the joystick page. This change handles the case in which two joysticks with the same name identifier are connected, in order to allow selecting between the two, instead of overwriting the first instance while we enumerate the second and then ending up with only one option in the dropdown.

@jaxxzer
Copy link
Collaborator Author

jaxxzer commented Jul 28, 2017

IMO, this does not have a docs impact. @hamishwillee

@hamishwillee
Copy link
Contributor

Thanks @jaxxzer

@DonLakeFlyer DonLakeFlyer merged commit a1c60f6 into mavlink:master Aug 3, 2017
@jaxxzer jaxxzer deleted the pr-joystick-duplicate-names branch August 3, 2017 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants