Rework vehicle sensors_health alert #5135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to noodle on this a bit. |
|
I think this is pretty close to something I'm happy with. But I'm going to wait till after 3.2 goes out to merge and/or change user model with small tweaks. |
|
Right on. |
|
@jaxxzer Can you rebase and then I'll take a look again and hopefully merge. |
jaxxzer
force-pushed
the
vehicle-health-alert
branch
from
2d0a86b to
b25fa29
Compare
|
@DonLakeFlyer done. |
DonLakeFlyer
reviewed
Aug 7, 2017
|
|
||
| property bool _warningsViewed: false | ||
|
|
||
| MouseArea { |
There was a problem hiding this comment.
Could you use a QGCMouseArea for this? This will cause it to automatically expand in size on touch systems. You set fillItem instead of doing an anchors.fill
There was a problem hiding this comment.
I'm going to merge and just change it over myself after the fact.
|
Thanks. @DonLakeFlyer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that automatically switching the page in the instrument panel every time the sensors_health flag changes is heavy-handed and obnoxious.
This pr changes the behavior to show a warning icon opposite the gearthingy beneath the attitude indicator. Click the warning icon to quickly switch to the sensors health page. The warning icon goes away until another sensors_health bit changes.