Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AMS (Auto Maneuver System, aka emergency descend) mode support #676

Closed
wants to merge 2 commits into from
Closed

Add AMS (Auto Maneuver System, aka emergency descend) mode support #676

wants to merge 2 commits into from

Conversation

bresch
Copy link

@bresch bresch commented Feb 19, 2019

This PR allows the SDK to trigger AMS on the flight controller introduced here:
PX4/PX4-Autopilot#11169

Example of how to use the code:

// AMS
std::cout << "Engaging AMS..." << std::endl;
const Action::Result ams_result = action->auto_maneuver_system();
if (takeoff_result != Action::Result::SUCCESS) {
std::cout << ERROR_CONSOLE_TEXT << "AMS failed:" << Action::result_str(ams_result)
<< NORMAL_CONSOLE_TEXT << std::endl;
return 1;
}

Copy link
Collaborator

@JonasVautherin JonasVautherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but you need to fix style. You can run the following command for that:

$ make fix_style

@julianoes
Copy link
Collaborator

julianoes commented Feb 20, 2019

Thanks for the pull request.

Is this AMS thing in PX4? Because I'm looking at https://github.com/PX4/Firmware/blob/master/src/modules/commander/px4_custom_mode.h and I don't see it there.

@julianoes
Copy link
Collaborator

@bresch please follow up.

@julianoes
Copy link
Collaborator

@bresch bump 😄

@JonasVautherin
Copy link
Collaborator

I updated the branch and fixed style, but the CI is still failing because the documentation is lacking fields.

@julianoes
Copy link
Collaborator

Thanks but also this is not in upstream yet anyway, so I'm confused how it even works.

@bresch
Copy link
Author

bresch commented Mar 14, 2019

Sorry I'm not really responsive here... It's not merged yet in the firmware because of some changes in the mission_item. I'll come to you @julianoes to discuss about that.

@julianoes
Copy link
Collaborator

Ok, this needs to wait for the PX4 change to be merged first then.

@julianoes
Copy link
Collaborator

Please re-open when it is merged in PX4 and we should consider it again.

@julianoes julianoes closed this Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants