-
-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AMS (Auto Maneuver System, aka emergency descend) mode support #676
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but you need to fix style. You can run the following command for that:
$ make fix_style
Thanks for the pull request. Is this AMS thing in PX4? Because I'm looking at https://github.com/PX4/Firmware/blob/master/src/modules/commander/px4_custom_mode.h and I don't see it there. |
@bresch please follow up. |
@bresch bump 😄 |
I updated the branch and fixed style, but the CI is still failing because the documentation is lacking fields. |
Thanks but also this is not in upstream yet anyway, so I'm confused how it even works. |
Sorry I'm not really responsive here... It's not merged yet in the firmware because of some changes in the |
Ok, this needs to wait for the PX4 change to be merged first then. |
Please re-open when it is merged in PX4 and we should consider it again. |
This PR allows the SDK to trigger AMS on the flight controller introduced here:
PX4/PX4-Autopilot#11169
Example of how to use the code: