Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UDP client connection syntax to use udpin:// #2380

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

KarthiAru
Copy link
Contributor

Changed all instances of the deprecated UDP client connection syntax udp://:PORT to the recommended udpin://:PORT following the deprecation warning: Connection using udp:// is deprecated, please use udpin:// or udpout:// (cli_arg.cpp:28)

Changed all instances of the deprecated UDP connection syntax udp://:PORT to the recommended udpin://:PORT following the deprecation warning:
Connection using udp:// is deprecated, please use udpin:// or udpout:// (cli_arg.cpp:28)
@KarthiAru
Copy link
Contributor Author

I haven't included the udpout:// related changes in this PR. Will raise a new PR after testing.

Copy link
Collaborator

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that! Note that it should be udpin://0.0.0.0:14540 though, with the new syntax.

Updated the binding address for the UDP connection from udpin://:PORT to udpin://0.0.0.0:PORT
@KarthiAru
Copy link
Contributor Author

Done. Updated to include 0.0.0.0

Copy link

Copy link
Collaborator

@JonasVautherin JonasVautherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@julianoes julianoes merged commit 3b779fb into mavlink:main Aug 20, 2024
33 checks passed
@KarthiAru KarthiAru deleted the pr-udp-fix branch August 23, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants