Add a BUILD_TESTING option to superbuild #2377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianoes
previously approved these changes
Aug 18, 2024
|
I don't get the CI failure 🙈. Everything seems fine, but gets cancelled somehow 🤔. There is a cache miss (that's expected), then it builds the dependencies, then it builds everything, and at the end somehow it marks everything as "cancelled" 🤔 🤔 🤔 |
|
No idea. I ran it again. |
|
|
It seems unrelated to this PR (see #2382). @julianoes what do you say: should we merge this? |
|
The CI issue is fixed in #2382, merging this one 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been a problem e.g. here and here. I think it makes sense to add an option for those who don't need to run the tests.
Also I renamed BUILD_TESTS to BUILD_TESTING, which is more common with CMake (that's actually the CTest way, I believe).