CI: fix macOS

[julianoes]

macOS tooling shifting from under you, it doesn't get much worse than that.
😠

[JonasVautherin]

Hmm this run failed because it received a "Command Denied" in the tests. I see that you already restarted it and it seems to fail consistently:

2024-08-05T05:05:03.6328830Z [ RUN      ] SystemTest.ActionArmDisarm
2024-08-05T05:05:04.7761950Z �[34m[05:05:03|Info ] �[0mMAVSDK version: v2.12.2-52-g57faa263 (mavsdk_impl.cpp:28)
2024-08-05T05:05:04.7765860Z �[34m[05:05:03|Info ] �[0mMAVSDK version: v2.12.2-52-g57faa263 (mavsdk_impl.cpp:28)
2024-08-05T05:05:04.7769940Z �[33m[05:05:03|Warn ] �[0mConnection using udp:// is deprecated, please use udpin:// or udpout:// (cli_arg.cpp:28)
2024-08-05T05:05:04.7780290Z �[33m[05:05:03|Warn ] �[0mConnection using udp:// is deprecated, please use udpin:// or udpout:// (cli_arg.cpp:28)
2024-08-05T05:05:04.7784810Z �[34m[05:05:03|Info ] �[0mNew system on: 127.0.0.1:57193 (with system ID: 1) (udp_connection.cpp:179)
2024-08-05T05:05:04.7788310Z �[32m[05:05:03|Debug] �[0mNew system ID: 1 Comp ID: 1 (mavsdk_impl.cpp:705)
2024-08-05T05:05:04.7791400Z �[32m[05:05:03|Debug] �[0mComponent Autopilot (1) added. (system_impl.cpp:367)
2024-08-05T05:05:04.7795890Z �[32m[05:05:04|Debug] �[0mDiscovered 1 component(s) (system_impl.cpp:510)
2024-08-05T05:05:04.7799280Z �[32m[05:05:04|Debug] �[0mNew system ID: 245 Comp ID: 190 (mavsdk_impl.cpp:705)
2024-08-05T05:05:04.7802630Z �[32m[05:05:04|Debug] �[0mComponent Ground station (190) added. (system_impl.cpp:367)
2024-08-05T05:05:04.7805920Z �[32m[05:05:04|Debug] �[0mDiscovered 1 component(s) (system_impl.cpp:510)
2024-08-05T05:05:04.7810260Z �[33m[05:05:04|Warn ] �[0msending again after 0.000163583 s, retries to do: 3  (520). (mavlink_command_sender.cpp:320)
2024-08-05T05:05:04.7814960Z �[33m[05:05:04|Warn ] �[0msending again after 0.000214375 s, retries to do: 3  (511). (mavlink_command_sender.cpp:320)
2024-08-05T05:05:04.7819250Z �[33m[05:05:04|Warn ] �[0msending again after 0.000212625 s, retries to do: 3  (400). (mavlink_command_sender.cpp:320)
2024-08-05T05:05:04.7822680Z �[33m[05:05:04|Warn ] �[0mReceived ack for not-existing command: 520! Ignoring... (mavlink_command_sender.cpp:288)
2024-08-05T05:05:04.7825580Z /Users/runner/work/MAVSDK/MAVSDK/src/system_tests/action_arm_disarm.cpp:37: Failure
2024-08-05T05:05:04.7827510Z Expected equality of these values:
2024-08-05T05:05:04.7828560Z   action.arm()
2024-08-05T05:05:04.7829380Z     Which is: Command Denied
2024-08-05T05:05:04.7830450Z   Action::Result::Success
2024-08-05T05:05:04.7831370Z     Which is: Success
2024-08-05T05:05:04.7831930Z 
2024-08-05T05:05:05.2679320Z �[33m[05:05:04|Warn ] �[0msending again after 0.0127569 s, retries to do: 2  (511). (mavlink_command_sender.cpp:320)
2024-08-05T05:05:05.2681100Z �[33m[05:05:04|Warn ] �[0msending again after 0.105803 s, retries to do: 1  (511). (mavlink_command_sender.cpp:320)
2024-08-05T05:05:05.2684090Z �[31m[05:05:04|Error] �[0mRetrying failed (511) (mavlink_command_sender.cpp:346)
2024-08-05T05:05:05.2684600Z [  FAILED  ] SystemTest.ActionArmDisarm (1634 ms)

I assume you were originally trying to fix https://github.com/mavlink/MAVSDK/actions/runs/10239332346/job/28329544137#step:9:19 😕.

For the record, the runner that is failing later in the process (gimbal) is:

Current runner version: '2.317.0'
Operating System
  macOS
  13.6.7
  22G720
Runner Image
  Image: macos-13
  Version: 20240728.2
  Included Software: https://github.com/actions/runner-images/blob/macos-13/20240728.2/images/macos/macos-13-Readme.md
  Image Release: https://github.com/actions/runner-images/releases/tag/macos-13%2F20240728.2

This runner:

Current runner version: '2.317.0'
Operating System
  macOS
  14.5
  23F79
Runner Image
  Image: macos-14-arm64
  Version: 20240728.1
  Included Software: https://github.com/actions/runner-images/blob/macos-14-arm64/20240728.1/images/macos/macos-14-arm64-Readme.md
  Image Release: https://github.com/actions/runner-images/releases/tag/macos-14-arm64%2F20240728.1

[julianoes]

Thanks, so now we're chasing two problems. Great.

[sonarqubecloud]

Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[julianoes]

Don't care about Sonar for this one.

[JonasVautherin]

Oh, I think I have seen this in the past... but I can't remember where (there are no other symlinks in this script, so probably somewhere else 🤔).

Good catch!