Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gimbal/info: fixups #2286

Merged
merged 2 commits into from
Apr 17, 2024
Merged

gimbal/info: fixups #2286

merged 2 commits into from
Apr 17, 2024

Conversation

julianoes
Copy link
Collaborator

Some fixups against lockups and subscriptions, both failing after re-discovery.

We finally don't lose the subscriptions any more after a timeout.

This is done by doing the subscription after every V2 instantiation
in the GimbalImpl class instead of within the V2 class.

Signed-off-by: Julian Oes <julian@oes.ch>
These happened when a system was re-discovered.

Signed-off-by: Julian Oes <julian@oes.ch>
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@julianoes julianoes merged commit 7b9655e into main Apr 17, 2024
27 of 28 checks passed
@julianoes julianoes deleted the pr-fixups branch April 17, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant